[PATCH] staging: sm750fb: modify function name to kernel code style

[PATCH] staging: sm750fb: modify function name to kernel code style

[Richard Akintola]

Change camelCase function name sii164ResetChip to sii164_reset_chip
as reported by checkpatch.pl

CHECK: Avoid camelCase: <sii164ResetChip>

Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
 drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
 drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
 drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 8b81e8642f9e..cc8ff3978d42 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
 		.get_vendor_id = sii164_get_vendor_id,
 		.get_device_id = sii164GetDeviceID,
 #ifdef SII164_FULL_FUNCTIONS
-		.reset_chip = sii164ResetChip,
+		.reset_chip = sii164_reset_chip,
 		.get_chip_string = sii164GetChipString,
 		.set_power = sii164SetPower,
 		.enable_hot_plug_detection = sii164EnableHotPlugDetection,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 2532b60245ac..795f8c86e3c0 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -250,10 +250,10 @@ long sii164_init_chip(unsigned char edge_select,
 #ifdef SII164_FULL_FUNCTIONS
 
 /*
- *  sii164ResetChip
+ *  sii164_reset_chip
  *      This function resets the DVI Controller Chip.
  */
-void sii164ResetChip(void)
+void sii164_reset_chip(void)
 {
 	/* Power down */
 	sii164SetPower(0);
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index 71a7c1cb42c4..a9edc9474f87 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -31,7 +31,7 @@ unsigned short sii164_get_vendor_id(void);
 unsigned short sii164GetDeviceID(void);
 
 #ifdef SII164_FULL_FUNCTIONS
-void sii164ResetChip(void);
+void sii164_reset_chip(void);
 char *sii164GetChipString(void);
 void sii164SetPower(unsigned char powerUp);
 void sii164EnableHotPlugDetection(unsigned char enableHotPlug);
-- 
2.39.5

Re: [PATCH] staging: sm750fb: modify function name to kernel code style

[Greg KH]

On Mon, Mar 31, 2025 at 09:53:36AM +0100, Richard Akintola wrote:
> Change camelCase function name sii164ResetChip to sii164_reset_chip
> as reported by checkpatch.pl
> 
> CHECK: Avoid camelCase: <sii164ResetChip>
> 
> Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
>  drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
>  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

You sent 2 different patches with different subject lines, yet they
almost did the same thing?  Which one should I take or review?  Please
send a new one, as a version 3, and properly document what changed
between this one and the last 2 submissions.

thanks,

greg k-h

Re: [PATCH] staging: sm750fb: modify function name to kernel code style

[Richard Akintola]

Hi,

Yes I did send two different patches (part of the reason I used
different subject lines),
they did similar things (change camelCase to snake_case,  I wanted to
get all done in the file,
but I learnt it is best done one at a time.

So should I have it all done in the file (there are more than 2
camelCase CHECKs), or send it
one after the other? (but you could take the first).

Thanks

Richard Akintola

On Thu, Apr 3, 2025 at 3:18 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Mar 31, 2025 at 09:53:36AM +0100, Richard Akintola wrote:
> > Change camelCase function name sii164ResetChip to sii164_reset_chip
> > as reported by checkpatch.pl
> >
> > CHECK: Avoid camelCase: <sii164ResetChip>
> >
> > Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
> >  drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
> >  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
> >  3 files changed, 4 insertions(+), 4 deletions(-)
>
> You sent 2 different patches with different subject lines, yet they
> almost did the same thing?  Which one should I take or review?  Please
> send a new one, as a version 3, and properly document what changed
> between this one and the last 2 submissions.
>
> thanks,
>
> greg k-h

Re: [PATCH] staging: sm750fb: modify function name to kernel code style

[Greg KH]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Thu, Apr 03, 2025 at 11:37:48PM +0100, Richard Akintola wrote:
> Hi,
> 
> Yes I did send two different patches (part of the reason I used
> different subject lines),
> they did similar things (change camelCase to snake_case,  I wanted to
> get all done in the file,
> but I learnt it is best done one at a time.
> 
> So should I have it all done in the file (there are more than 2
> camelCase CHECKs), or send it
> one after the other? (but you could take the first).

Please send it as a patch series.

thanks,

greg k-h

Re: [PATCH] staging: sm750fb: modify function name to kernel code style

[Richard Akintola]

On Fri, Apr 4, 2025 at 7:22 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
>
> http://daringfireball.net/2007/07/on_top

Thank you for educating me on top-posting, and I really appreciate that it was
given in a top-posting style making me realise the consequences by experience.

> Please send it as a patch series.

I will send in the patch series as advised.

Richard Akintola