From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F1AEB64DD for ; Thu, 29 Jun 2023 12:55:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231657AbjF2MzR (ORCPT ); Thu, 29 Jun 2023 08:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjF2MzQ (ORCPT ); Thu, 29 Jun 2023 08:55:16 -0400 Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB5C2961; Thu, 29 Jun 2023 05:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1688043306; bh=qlzO1nAzqPvB+Hzmr0HgbCqGg7RmBSNwRMReUr64bck=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jUu9zRsEygCOa39ZCgxRiLbKjXTQyAk3/vq1UdG1rNhZGoBj1lnigTzep51CpGxAI Bi14AsqbPSnMerzIsKznCyRo9Sr6o9nEuXrSMeAlj3HQr2VxpcMMRF4Ii1rtyOqAct kG/wvCT5WHvifhVE0+KGx6hx6hBDjd766/gHEM8M= Received: from [100.100.34.13] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id D6696600AE; Thu, 29 Jun 2023 20:55:02 +0800 (CST) Message-ID: <6906281a-baa8-a960-e679-69d1e714e713@xen0n.name> Date: Thu, 29 Jun 2023 20:55:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 06/12] arch: Declare screen_info in Content-Language: en-US To: Thomas Zimmermann , arnd@arndb.de, deller@gmx.de, daniel@ffwll.ch, airlied@gmail.com Cc: linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arch@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , Thomas Bogendoerfer , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Kees Cook , "Paul E. McKenney" , Peter Zijlstra , Frederic Weisbecker , Andrew Morton , Ard Biesheuvel , Sami Tolvanen , Juerg Haefliger , Geert Uytterhoeven , Anshuman Khandual , Niklas Schnelle , "Russell King (Oracle)" , Linus Walleij , Sebastian Reichel , "Mike Rapoport (IBM)" , "Kirill A. Shutemov" , Zi Yan References: <20230629121952.10559-1-tzimmermann@suse.de> <20230629121952.10559-7-tzimmermann@suse.de> From: WANG Xuerui In-Reply-To: <20230629121952.10559-7-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 2023/6/29 19:45, Thomas Zimmermann wrote: > The variable screen_info does not exist on all architectures. Declare > it in . All architectures that do declare it > will provide it via . > > Add the Kconfig token ARCH_HAS_SCREEN_INFO to guard against access on > architectures that don't provide screen_info. > > Signed-off-by: Thomas Zimmermann > Cc: Richard Henderson > Cc: Ivan Kokshaysky > Cc: Matt Turner > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Guo Ren > Cc: Brian Cain > Cc: Huacai Chen > Cc: WANG Xuerui > Cc: Thomas Bogendoerfer > Cc: Dinh Nguyen > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: Chris Zankel > Cc: Max Filippov > Cc: Helge Deller > Cc: Arnd Bergmann > Cc: Kees Cook > Cc: "Paul E. McKenney" > Cc: Peter Zijlstra > Cc: Frederic Weisbecker > Cc: Andrew Morton > Cc: Ard Biesheuvel > Cc: Sami Tolvanen > Cc: Juerg Haefliger > Cc: Geert Uytterhoeven > Cc: Anshuman Khandual > Cc: Niklas Schnelle > Cc: "Russell King (Oracle)" > Cc: Linus Walleij > Cc: Sebastian Reichel > Cc: "Mike Rapoport (IBM)" > Cc: "Kirill A. Shutemov" > Cc: Zi Yan > --- > arch/Kconfig | 6 ++++++ > arch/alpha/Kconfig | 1 + > arch/arm/Kconfig | 1 + > arch/arm64/Kconfig | 1 + > arch/csky/Kconfig | 1 + > arch/hexagon/Kconfig | 1 + > arch/ia64/Kconfig | 1 + > arch/loongarch/Kconfig | 1 + > arch/mips/Kconfig | 1 + > arch/nios2/Kconfig | 1 + > arch/powerpc/Kconfig | 1 + > arch/riscv/Kconfig | 1 + > arch/sh/Kconfig | 1 + > arch/sparc/Kconfig | 1 + > arch/x86/Kconfig | 1 + > arch/xtensa/Kconfig | 1 + > drivers/video/Kconfig | 3 +++ > include/asm-generic/Kbuild | 1 + > include/asm-generic/screen_info.h | 12 ++++++++++++ > include/linux/screen_info.h | 2 +- > 20 files changed, 38 insertions(+), 1 deletion(-) > create mode 100644 include/asm-generic/screen_info.h > > diff --git a/arch/Kconfig b/arch/Kconfig > index 205fd23e0cada..2f58293fd7bcb 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -1466,6 +1466,12 @@ config ARCH_HAS_NONLEAF_PMD_YOUNG > address translations. Page table walkers that clear the accessed bit > may use this capability to reduce their search space. > > +config ARCH_HAS_SCREEN_INFO > + bool > + help > + Selected by architectures that provide a global instance of > + screen_info. > + > source "kernel/gcov/Kconfig" > > source "scripts/gcc-plugins/Kconfig" > [snip] > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > index d38b066fc931b..6aab2fb7753da 100644 > --- a/arch/loongarch/Kconfig > +++ b/arch/loongarch/Kconfig > @@ -13,6 +13,7 @@ config LOONGARCH > select ARCH_HAS_FORTIFY_SOURCE > select ARCH_HAS_NMI_SAFE_THIS_CPU_OPS > select ARCH_HAS_PTE_SPECIAL > + select ARCH_HAS_SCREEN_INFO > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > select ARCH_INLINE_READ_LOCK if !PREEMPTION > select ARCH_INLINE_READ_LOCK_BH if !PREEMPTION > [snip] Acked-by: WANG Xuerui # loongarch Thanks! -- WANG "xen0n" Xuerui Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/