* [PATCH] fbdev: fix omap2/omapfb/dss/ indentation warning
@ 2018-07-22 3:16 ` Randy Dunlap
2018-07-24 17:00 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-07-22 3:16 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, linux-fbdev, dri-devel; +Cc: linux-omap
From: Randy Dunlap <rdunlap@infradead.org>
Fix indentation warning (from gcc 8.1.0) in omap2/omapfb:
../drivers/video/fbdev/omap2/omapfb/dss/dispc.c: In function 'pixinc':
../drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1859:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
../drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1861:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
return 0;
^~~~~~
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-omap@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20180717.orig/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
+++ linux-next-20180717/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
@@ -1858,7 +1858,7 @@ static s32 pixinc(int pixels, u8 ps)
return 1 - (-pixels + 1) * ps;
else
BUG();
- return 0;
+ return 0;
}
static void calc_vrfb_rotation_offset(u8 rotation, bool mirror,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: fix omap2/omapfb/dss/ indentation warning
2018-07-22 3:16 ` [PATCH] fbdev: fix omap2/omapfb/dss/ indentation warning Randy Dunlap
@ 2018-07-24 17:00 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-07-24 17:00 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-fbdev, linux-omap, dri-devel
On Saturday, July 21, 2018 08:16:09 PM Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix indentation warning (from gcc 8.1.0) in omap2/omapfb:
>
> ../drivers/video/fbdev/omap2/omapfb/dss/dispc.c: In function 'pixinc':
> ../drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1859:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
> else
> ^~~~
> ../drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1861:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
> return 0;
> ^~~~~~
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: linux-omap@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-24 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180722031614epcas3p180b7f14a540d6913e70c2308651fe4f1@epcas3p1.samsung.com>
2018-07-22 3:16 ` [PATCH] fbdev: fix omap2/omapfb/dss/ indentation warning Randy Dunlap
2018-07-24 17:00 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).