From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Paul Adrian Glaubitz Date: Tue, 02 Jun 2020 11:07:33 +0000 Subject: Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support Message-Id: <6d17452e-29ee-76dd-759c-b39d87bb82b8@physik.fu-berlin.de> List-Id: References: <839133dd-8ed4-5fec-c311-ce9f8abf3d5f@samsung.com> <72e0871c-d4bb-4887-4d6f-a60fd905bec1@physik.fu-berlin.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Linux Fbdev development list , Bartlomiej Zolnierkiewicz , Linux Kernel Mailing List , DRI Development , linux-m68k , Al Viro Hi! On 6/2/20 1:04 PM, Geert Uytterhoeven wrote: >> What do you mean with the sentence "when arch/ppc/ was still king"? > > Ah, Bartl copied that from my email ;-) > > There used to be APUS support under arch/ppc/. > Later, 32-bit arch/ppc/ and 64-bit arch/ppc64/ were merged in a new\ > architecture port under arch/powerpc/, and the old ones were dropped. > APUS was never converted, and thus dropped. Ah, yes. Similar to the merge with x86. >> Does that mean - in the case we would re-add APUS support in the future, that >> these particular changes would not be necessary? > > They would still be necessary, as PowerPC doesn't grok m68k instructions. > Alternatively, we could just drop the m68k inline asm, and retain the C > version instead? I have no idea how big of a difference that would make > on m68k, using a more modern compiler than when the code was written > originally. Hmm, no idea. I would keep the assembly for the time being. This was just a question out of curiosity. We could still consider such a change if someone should consider working on APUS support again. > Note that all of this is used only for cursor handling, which I doubt is > actually used by any user space application. The only exception is the > DIVUL() macro, which is used once during initialization, thus also not > performance critical. I see, thanks. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913