Re: [PATCH v3 0/2] Fixes for omapdrm console

[Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>]

Hi,

On 28/02/2024 08:35, Tony Lindgren wrote:
> Here are two fixes for omapdrm for missing drm_framebuffer_funcs.dirty
> that needs to be paired with omap_framebuffer_dirty(), and to add
> FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS so things behave as earlier with
> drm_fb_helper_sys_write(). Without these fixes, the console won't update
> for the command mode displays. And likely mmap() using writes can miss
> updates as noted by Thomas.
> 
> Regards,
> 
> Tony
> 
> Changes since v2:
> - Fix cache issue noted by Tomi using custom omap_fbdev_fb_mmap() as
>    suggested by Thomas
> 
> - Add FB_DMAMEM_HELPERS_DEFERRED Kconfig option and use it for omapdrm
>    as noted by Thomas
> 
> Changes since v1:
> 
> - Add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS to use with
>    FB_DEFAULT_DEFERRED_OPS as suggested by Thomas
> 
> Tony Lindgren (2):
>    drm/omapdrm: Fix console by implementing fb_dirty
>    drm/omapdrm: Fix console with deferred ops
> 
>   drivers/gpu/drm/omapdrm/Kconfig      |  2 +-
>   drivers/gpu/drm/omapdrm/omap_fbdev.c | 40 +++++++++++++++++++++++-----
>   drivers/video/fbdev/core/Kconfig     |  6 +++++
>   include/linux/fb.h                   |  4 +++
>   4 files changed, 45 insertions(+), 7 deletions(-)
> 

Looks fine to me, I'll apply to drm-misc-next.

  Tomi