From: Randy Dunlap <rdunlap@infradead.org>
To: "Duje Mihanović" <duje@dujemihanovic.xyz>,
"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@kernel.org>,
"Daniel Thompson" <danielt@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] leds: Drop duplicate LEDS_EXPRESSWIRE config
Date: Tue, 29 Jul 2025 16:31:59 -0700 [thread overview]
Message-ID: <70e9842b-83dc-44f8-b27d-260ff9543b36@infradead.org> (raw)
In-Reply-To: <20250729-expresswire-dep-fix-v1-1-635cd4cc746b@dujemihanovic.xyz>
On 7/29/25 10:18 AM, Duje Mihanović wrote:
> While moving said config symbol out of the "if NEW_LEDS" block, I
> accidentally left a copy inside that block. Remove it.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/all/b6c481bb-e854-405e-a428-90301789fe20@infradead.org/
s/Link/Closes/
> Fixes: 2cd0d1db31e7 ("leds: expresswire: Don't depend on NEW_LEDS")
> Signed-off-by: Duje Mihanović <duje@dujemihanovic.xyz>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/leds/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 6e3dce7e35a490df050cb4cd8e98611028c8dce1..8098b7b49c9decb591a894fe514a7ee757da5b44 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -214,10 +214,6 @@ config LEDS_EL15203000
> To compile this driver as a module, choose M here: the module
> will be called leds-el15203000.
>
> -config LEDS_EXPRESSWIRE
> - bool
> - depends on GPIOLIB
> -
> config LEDS_TURRIS_OMNIA
> tristate "LED support for CZ.NIC's Turris Omnia"
> depends on LEDS_CLASS_MULTICOLOR
>
--
~Randy
next prev parent reply other threads:[~2025-07-29 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 17:18 [PATCH 0/2] ExpressWire dependency fixes Duje Mihanović
2025-07-29 17:18 ` [PATCH 1/2] leds: Drop duplicate LEDS_EXPRESSWIRE config Duje Mihanović
2025-07-29 23:31 ` Randy Dunlap [this message]
2025-10-30 11:47 ` Daniel Thompson
2025-11-06 16:58 ` (subset) " Lee Jones
2025-07-29 17:18 ` [PATCH 2/2] backlight: ktd2801: Depend on GPIOLIB Duje Mihanović
2025-07-29 23:32 ` Randy Dunlap
2025-10-30 11:48 ` Daniel Thompson
2025-11-06 16:56 ` (subset) " Lee Jones
2025-11-06 16:56 ` [PATCH 0/2] ExpressWire dependency fixes Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e9842b-83dc-44f8-b27d-260ff9543b36@infradead.org \
--to=rdunlap@infradead.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=duje@dujemihanovic.xyz \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).