linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] video: fbdev: constify copied structures
Date: Fri, 18 Aug 2017 17:41:16 +0000	[thread overview]
Message-ID: <7127868.v7Fj1TocLv@amdc3058> (raw)
In-Reply-To: <1501664679-10356-1-git-send-email-Julia.Lawall@lip6.fr>


Hi,

On Wednesday, August 02, 2017 11:04:39 AM Julia Lawall wrote:
> Make const some structures that are only copied into other structures.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

fb_fix_screeninfo and fb_var_screeninfo structures were already
const-ified by commit 40445365a43f ("video: xilinxfb: constify
fb_fix_screeninfo and fb_var_screeninfo structures") in my -next
tree (git://github.com/bzolnier/linux.git fbdev-for-next) so
I just applied xilinx_fb_default_pdata part (patch included below
for reference).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


From: Julia Lawall <Julia.Lawall@lip6.fr>
Subject: [PATCH] video: fbdev: xilinxfb: constify copied structure

Make const xilinx_fb_default_pdata structure that is only copied into
other structure.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Soren Brinkmann <soren.brinkmann@xilinx.com>,
[b.zolnierkie: split from a bigger patch]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/video/fbdev/xilinxfb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/video/fbdev/xilinxfb.c
=================================--- a/drivers/video/fbdev/xilinxfb.c	2017-08-18 19:34:11.383004874 +0200
+++ b/drivers/video/fbdev/xilinxfb.c	2017-08-18 19:34:35.383005478 +0200
@@ -100,7 +100,7 @@ struct xilinxfb_platform_data {
 /*
  * Default xilinxfb configuration
  */
-static struct xilinxfb_platform_data xilinx_fb_default_pdata = {
+static const struct xilinxfb_platform_data xilinx_fb_default_pdata = {
 	.xres = 640,
 	.yres = 480,
 	.xvirt = 1024,


      reply	other threads:[~2017-08-18 17:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170802093008epcas2p48a98827ec2c27fbd6f6de8913d47c02b@epcas2p4.samsung.com>
2017-08-02  9:04 ` [PATCH] video: fbdev: constify copied structures Julia Lawall
2017-08-18 17:41   ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7127868.v7Fj1TocLv@amdc3058 \
    --to=b.zolnierkie@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).