* [PATCH] fbdev: clps711x-fb: Remove dead code
@ 2024-10-04 1:43 Qianqiang Liu
2024-10-04 14:02 ` Thomas Zimmermann
0 siblings, 1 reply; 2+ messages in thread
From: Qianqiang Liu @ 2024-10-04 1:43 UTC (permalink / raw)
To: deller; +Cc: tzimmermann, linux-fbdev, linux-kernel
The code can never be reached: unregister_framebuffer(info);
Fixes: 36462ac19308 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev")
Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
---
drivers/video/fbdev/clps711x-fb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
index 9e3df1df5ac4..b57134bc63e7 100644
--- a/drivers/video/fbdev/clps711x-fb.c
+++ b/drivers/video/fbdev/clps711x-fb.c
@@ -332,8 +332,6 @@ static int clps711x_fb_probe(struct platform_device *pdev)
return 0;
- unregister_framebuffer(info);
-
out_fb_dealloc_cmap:
regmap_update_bits(cfb->syscon, SYSCON_OFFSET, SYSCON1_LCDEN, 0);
fb_dealloc_cmap(&info->cmap);
--
2.46.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: clps711x-fb: Remove dead code
2024-10-04 1:43 [PATCH] fbdev: clps711x-fb: Remove dead code Qianqiang Liu
@ 2024-10-04 14:02 ` Thomas Zimmermann
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Zimmermann @ 2024-10-04 14:02 UTC (permalink / raw)
To: Qianqiang Liu, deller; +Cc: linux-fbdev, linux-kernel
Hi
Am 04.10.24 um 03:43 schrieb Qianqiang Liu:
> The code can never be reached: unregister_framebuffer(info);
>
> Fixes: 36462ac19308 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev")
> Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/clps711x-fb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index 9e3df1df5ac4..b57134bc63e7 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -332,8 +332,6 @@ static int clps711x_fb_probe(struct platform_device *pdev)
>
> return 0;
>
> - unregister_framebuffer(info);
> -
This used to be code for error rollback, but is now unused. Thanks for
fixing the issue.
Best regards
Thomas
> out_fb_dealloc_cmap:
> regmap_update_bits(cfb->syscon, SYSCON_OFFSET, SYSCON1_LCDEN, 0);
> fb_dealloc_cmap(&info->cmap);
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-04 14:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04 1:43 [PATCH] fbdev: clps711x-fb: Remove dead code Qianqiang Liu
2024-10-04 14:02 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).