From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b2-smtp.messagingengine.com (fhigh-b2-smtp.messagingengine.com [202.12.124.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C1B371D0A; Thu, 2 Apr 2026 13:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775135373; cv=none; b=j2ETmJzodBJG/m7nYDRAWGOWOG0gxZzUXSJxY2s84ycvtwufKOs+Yjie9jCPYq1QMlgcaB1VflQ+i+7mBJYqdxZbYkvtrmvTE0df79dFbopykXk4SeuZ0laxzx1dlH5BfoxCrCd/CuH9mJdR4znHdwfUY934hc2hRMN0gpG5Y+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775135373; c=relaxed/simple; bh=+IvFOuVs28xANyS/ogfV1Pq/Sq/UwTNttO7Vn4bEkv0=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=Wvx+Yx7HcGSHHgyJ793lhgG6Us4Y13RtD+K41Juuu+2aqLxGsTSdup+k1GJNQcHEPDhZBhjdotEINS1fXUHe6BQOs4+EpoR/CBbsDC3oLHrqycuTXDWxNlBT7wI01eu4YKHHXyYEvv+kzZN7aVs1cu/l9zWMmIMZ6CEmHhjKWSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=FBxYlgk5; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=agPYXQIZ; arc=none smtp.client-ip=202.12.124.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="FBxYlgk5"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="agPYXQIZ" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 4567A7A011F; Thu, 2 Apr 2026 09:09:26 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-04.internal (MEProxy); Thu, 02 Apr 2026 09:09:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1775135366; x=1775221766; bh=44e76YJxkd5q+hgUlWAXtOLYIJKiZNYp0nUsEzVCRk0=; b= FBxYlgk5LwTbC6Hd0pYsekY+cj/43xfDic3Nq5KUYXIuAByjWcQC/4MynK8EvGyv Uexk61LrbgEEKfXkfTlK/shMDYl5tyAn5shj5yTVpfPkur7h2UHMqxssu5nPxFoa 8vRfS2ciCetboKjFIxSqY/FCKB4xHDco2m54AOjrLpQIp74wqvRjCB/NWCddnFbT 0OTw/HpU2+VuBssb4bSjrLHtUqxuTg6rsGhW5fhjLiN2JmVBTYGLY7+coU3dR9Xh kqkSyJqdDab0AXssZVE+URd2eVr0yDCGcxJxKLmiq6mHj7HSPdlt4CCQUxUTgVUD sPIHM0gA5KivuyxhzN/y+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1775135366; x= 1775221766; bh=44e76YJxkd5q+hgUlWAXtOLYIJKiZNYp0nUsEzVCRk0=; b=a gPYXQIZnT60HzAt2D0PVne9tKUzCK0FsozqUq7cu6ndYiCt4Z/zV7H3GR6snL8YH Nia8I0kaiAnShNcTT/6fGyjj95fpYvgUCc2AH+6xSurhsnlZ0/6xukuewVctmEsx caolHX6d3alkzc44sfHAEk/0YOY+sjm4Ulbwnunt1Z9c/aHUj2GGIQ5OaUk7ZUqB qY8rSjZg92tjU6RaPqkWQnkAXLL5Jlys5BzrZH/DGIlwyuvhzujN3faH5snylGiP c8fS9Rb3CO+ArMxP1zOFsIDznAp7cTRsV6Szkag3nisaBKJyi+L/Guz8OyI468i/ XwUvWnLeDj7G6x+YHKoMg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdeiudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrnhguuceu vghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrthhtvghrnh ephfdthfdvtdefhedukeetgefggffhjeeggeetfefggfevudegudevledvkefhvdeinecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhguse grrhhnuggsrdguvgdpnhgspghrtghpthhtohepvdefpdhmohguvgepshhmthhpohhuthdp rhgtphhtthhopehsihhmohhnrgesfhhffihllhdrtghhpdhrtghpthhtoheprghirhhlih gvugesghhmrghilhdrtghomhdprhgtphhtthhopeguvghllhgvrhesghhmgidruggvpdhr tghpthhtoheprghruggssehkvghrnhgvlhdrohhrghdprhgtphhtthhopegthhgvnhhhuh grtggriheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepmhhrihhprghrugeskhgvrhhn vghlrdhorhhgpdhrtghpthhtohepfigvihdrlhhiuheskhgvrhhnvghlrdhorhhgpdhrtg hpthhtohepihhlihgrshdrrghprghlohguihhmrghssehlihhnrghrohdrohhrghdprhgt phhtthhopehmrggrrhhtvghnrdhlrghnkhhhohhrshhtsehlihhnuhigrdhinhhtvghlrd gtohhm X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 462A2700065; Thu, 2 Apr 2026 09:09:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: ATYY62_w4Fts Date: Thu, 02 Apr 2026 15:08:43 +0200 From: "Arnd Bergmann" To: "Thomas Zimmermann" , "Javier Martinez Canillas" , "Ard Biesheuvel" , "Ilias Apalodimas" , "Huacai Chen" , "WANG Xuerui" , "Maarten Lankhorst" , "Maxime Ripard" , "Dave Airlie" , "Simona Vetter" , "K. Y. Srinivasan" , "Haiyang Zhang" , "Wei Liu" , "Dexuan Cui" , longli@microsoft.com, "Helge Deller" Cc: linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-fbdev@vger.kernel.org Message-Id: <78f76717-8f1e-41d6-92f7-261df96b84b6@app.fastmail.com> In-Reply-To: <20260402092305.208728-4-tzimmermann@suse.de> References: <20260402092305.208728-1-tzimmermann@suse.de> <20260402092305.208728-4-tzimmermann@suse.de> Subject: Re: [PATCH 3/8] firmware: sysfb: Make CONFIG_SYSFB a user-selectable option Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Apr 2, 2026, at 11:09, Thomas Zimmermann wrote: > Add a descriptive string and help text to CONFIG_SYSFB, so that users > can modify it. Flip all implicit selects in the Kconfig options into > dependencies. This avoids cyclic dependencies in the config. > > Enabling CONFIG_SYSFB makes the kernel provide a device for the firmware > framebuffer. As this can (slightly) affect system behavior, having a > user-facing option seems preferable. Some users might also want to set > every detail of their kernel config. > > Signed-off-by: Thomas Zimmermann I don't really like this part of the series and would prefer to keep CONFIG_SYSFB hidden as much as possible as an x86 (and EFI) specific implementation detail, with the hope of eventually seperating out the x86 bits from the EFI ones. In general, I am always in favor of properly using Kconfig dependencies over 'select' statements, for the same reasons you describe, but I don't want the the x86 logic for the legacy VESA and VGA console handling to leak into more architectures than necessary. Do you think we could instead move the sysfb_init() function into the same two places that contain the sysfb_primary_display definition (arch/x86/kernel/setup.c, drivers/firmware/efi/efi-init.c) and simplify the efi version to take out the x86 bits? That would reduce the rest of sysfb-primary.c to the logic to unregister the device, and that could then be selected by both x86 and EFI. Arnd