From: Hans de Goede <hdegoede@redhat.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Peter Jones <pjones@redhat.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] efifb: BGRT: Improve efifb_bgrt_sanity_check
Date: Mon, 19 Aug 2019 14:02:15 +0000 [thread overview]
Message-ID: <7a2f6fed-c059-6d56-52e5-326f0e44bc6f@redhat.com> (raw)
In-Reply-To: <9da1b656-4640-fe16-9def-fe6c069ed39e@samsung.com>
Hi,
On 19-08-19 16:01, Bartlomiej Zolnierkiewicz wrote:
>
> On 8/17/19 10:40 AM, Hans de Goede wrote:
>> Hi,
>
> Hi Hans,
>
>> On 21-07-19 15:19, Hans de Goede wrote:
>>> For various reasons, at least with x86 EFI firmwares, the xoffset and
>>> yoffset in the BGRT info are not always reliable.
>>>
>>> Extensive testing has shown that when the info is correct, the
>>> BGRT image is always exactly centered horizontally (the yoffset variable
>>> is more variable and not always predictable).
>>>
>>> This commit simplifies / improves the bgrt_sanity_check to simply
>>> check that the BGRT image is exactly centered horizontally and skips
>>> (re)drawing it when it is not.
>>>
>>> This fixes the BGRT image sometimes being drawn in the wrong place.
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 88fe4ceb2447 ("efifb: BGRT: Do not copy the boot graphics for non native resolutions")
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> ping? I do not see this one in -next yet, what is the status of this
>> patch?
> Patch queued for v5.4, thanks and sorry for the delay.
No problem, thank you all the maintainer work you do on fbdev.
Regards,
Hans
prev parent reply other threads:[~2019-08-19 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 13:19 [PATCH] efifb: BGRT: Improve efifb_bgrt_sanity_check Hans de Goede
2019-08-17 8:40 ` Hans de Goede
2019-08-19 14:01 ` Bartlomiej Zolnierkiewicz
2019-08-19 14:02 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a2f6fed-c059-6d56-52e5-326f0e44bc6f@redhat.com \
--to=hdegoede@redhat.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).