From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B905C433EF for ; Thu, 14 Jul 2022 10:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238233AbiGNKVy (ORCPT ); Thu, 14 Jul 2022 06:21:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237809AbiGNKVx (ORCPT ); Thu, 14 Jul 2022 06:21:53 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4BE1222B7; Thu, 14 Jul 2022 03:21:51 -0700 (PDT) X-UUID: b2b634651a5e41c693ba2f87c87e5099-20220714 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:48061111-a145-4f1d-ba54-267d8bf77698,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:0f94e32,CLOUDID:142cfb32-b9e4-42b8-b28a-6364427c76bb,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: b2b634651a5e41c693ba2f87c87e5099-20220714 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 800925553; Thu, 14 Jul 2022 18:21:45 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 14 Jul 2022 18:21:44 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 14 Jul 2022 18:21:42 +0800 Message-ID: <7c847b4177b9420b98bd6ecde473f149463e50b1.camel@mediatek.com> Subject: Re: [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver From: CK Hu To: Rex-BC Chen , "chunkuang.hu@kernel.org" , "p.zabel@pengutronix.de" , "daniel@ffwll.ch" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "mripard@kernel.org" , "tzimmermann@suse.de" , "matthias.bgg@gmail.com" , "deller@gmx.de" , "airlied@linux.ie" CC: "msp@baylibre.com" , "granquet@baylibre.com" , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= , "wenst@chromium.org" , "angelogioacchino.delregno@collabora.com" , LiangXu Xu =?UTF-8?Q?=28=E5=BE=90=E4=BA=AE=29?= , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-fbdev@vger.kernel.org" , Project_Global_Chrome_Upstream_Group Date: Thu, 14 Jul 2022 18:21:41 +0800 In-Reply-To: References: <20220712111223.13080-1-rex-bc.chen@mediatek.com> <20220712111223.13080-6-rex-bc.chen@mediatek.com> <8fad0421bb7a61ae5e2ecabfc93790f1e2f30b63.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi, Bo-Chen: On Thu, 2022-07-14 at 16:24 +0800, Rex-BC Chen wrote: > On Wed, 2022-07-13 at 16:10 +0800, CK Hu wrote: > > Hi, Bo-Chen: > > > > On Tue, 2022-07-12 at 19:12 +0800, Bo-Chen Chen wrote: > > > From: Markus Schneider-Pargmann > > > > > > This patch adds a embedded displayport driver for the MediaTek > > > mt8195 > > > SoC. > > > > > > It supports the MT8195, the embedded DisplayPort units. It offers > > > DisplayPort 1.4 with up to 4 lanes. > > > > > > The driver creates a child device for the phy. The child device > > > will > > > never exist without the parent being active. As they are sharing > > > a > > > register range, the parent passes a regmap pointer to the child > > > so > > > that > > > both can work with the same register range. The phy driver sets > > > device > > > data that is read by the parent to get the phy device that can be > > > used > > > to control the phy properties. > > > > > > This driver is based on an initial version by > > > Jitao shi > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > Signed-off-by: Guillaume Ranquet > > > Signed-off-by: Bo-Chen Chen > > > --- > > > > [snip] > > > > > + > > > +struct mtk_dp_timings { > > > + struct videomode vm; > > > +}; > > > + > > > +struct mtk_dp_irq_sta { > > > + bool hpd_inerrupt; > > > +}; > > > + > > > +struct mtk_dp_train_info { > > > + bool tps3; > > > + bool tps4; > > > + bool sink_ssc; > > > + bool cable_plugged_in; > > > + bool cable_state_change; > > > + bool cr_done; > > > + bool eq_done; > > > + /* link_rate is in multiple of 0.27Gbps */ > > > + int link_rate; > > > + int lane_count; > > > + struct mtk_dp_irq_sta irq_sta; > > > > There is only one member in struct mtk_dp_irq_sta, so drop struct > > mtk_dp_irq_sta and use bool hpd_inerrupt directly here. > > > > Hello CK, > > ok, I will drop this. > > > > +}; > > > + > > > +struct mtk_dp_info { > > > + u32 depth; > > > + enum dp_pixelformat format; > > > + struct mtk_dp_timings timings; > > > > There is only one member in struct mtk_dp_timings, so drop struct > > mtk_dp_timings and use struct videomode vm directly here. > > > > This structure will add more variable in following patch. > whole struct is like, > struct mtk_dp_timings { > struct videomode vm; > u8 frame_rate; > u32 pix_rate_khz; > }; > > I want to keep this. I think we could just drop struct mtk_dp_timings and place these member directly in struct mtk_dp_info. Regards, CK > > BRs, > Bo-Chen > > > > Regards, > > CK > > > > > +}; > > > + > > > > > >