From: Javier Martinez Canillas <javierm@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Maxime Ripard" <maxime@cerno.tech>
Subject: Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays
Date: Tue, 1 Feb 2022 12:40:56 +0100 [thread overview]
Message-ID: <7f4569d5-2b67-fd98-9a0e-03a2025ddcce@redhat.com> (raw)
In-Reply-To: <YfkAOiSlIMZrKXyl@smile.fi.intel.com>
On 2/1/22 10:41, Andy Shevchenko wrote:
> On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote:
>> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:
>
> ...
>
>>> +config TINYDRM_SSD1307
>>> + tristate "DRM support for Solomon SSD1307 OLED displays"
>> Use SSD130X here - so SSD1306 users can find it.
>
> It's better to list them all in the "help". How user would grep this?
>
> `git grep -n -i ssd1306` ==> no match.
>
That's already the case :)
$ git grep -n -i ssd1306 drivers/gpu/drm/
drivers/gpu/drm/tiny/Kconfig:167: DRM driver for the SSD1305, SSD1306, SSD1307 and SSD1309 Solomon
drivers/gpu/drm/tiny/ssd1307.c:922:static struct ssd1307_deviceinfo ssd1307_ssd1306_deviceinfo = {
drivers/gpu/drm/tiny/ssd1307.c:948: .compatible = "solomon,ssd1306fb-i2c",
drivers/gpu/drm/tiny/ssd1307.c:949: .data = (void *)&ssd1307_ssd1306_deviceinfo,
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
prev parent reply other threads:[~2022-02-01 11:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 20:29 [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Javier Martinez Canillas
2022-02-01 9:33 ` Thomas Zimmermann
2022-02-01 9:48 ` Andy Shevchenko
2022-02-01 13:01 ` Javier Martinez Canillas
2022-02-01 14:05 ` Geert Uytterhoeven
2022-02-01 14:36 ` Javier Martinez Canillas
2022-02-02 8:23 ` Thomas Zimmermann
2022-02-02 8:29 ` Javier Martinez Canillas
[not found] ` <YfhVBtv1UIA7bJja@ravnborg.org>
2022-02-01 0:14 ` Javier Martinez Canillas
2022-02-01 9:44 ` Andy Shevchenko
2022-02-01 11:45 ` Javier Martinez Canillas
2022-02-01 14:02 ` Andy Shevchenko
2022-02-01 15:10 ` Javier Martinez Canillas
2022-02-01 9:41 ` Andy Shevchenko
2022-02-01 11:40 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f4569d5-2b67-fd98-9a0e-03a2025ddcce@redhat.com \
--to=javierm@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).