[PATCH 0/3] fbdev: Set missing owner fields in fb_ops

[PATCH 0/3] fbdev: Set missing owner fields in fb_ops

[Thomas Zimmermann]

Set the owner field of various drivers' fb_ops instance. The
setting is required by fbcon, which acquires a reference on the
fbdev driver's module. Otherwise, users could attempt to unload
the module while it's still in use.

Thomas Zimmermann (3):
  fbdev/68328fb: Init owner field of struct fb_ops
  fbdev/ps3fb: Init owner field of struct fb_ops
  fbdev/vfb: Init owner field of struct fb_ops

 drivers/video/fbdev/68328fb.c | 1 +
 drivers/video/fbdev/ps3fb.c   | 1 +
 drivers/video/fbdev/vfb.c     | 1 +
 3 files changed, 3 insertions(+)

-- 
2.40.0

[PATCH 1/3] fbdev/68328fb: Init owner field of struct fb_ops

[Thomas Zimmermann]

Initialize the owner field of struct fb_ops. Required to prevent
module unloading while the driver is in use.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/68328fb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c
index ef49cdfb7dd2..07d6e8dc686b 100644
--- a/drivers/video/fbdev/68328fb.c
+++ b/drivers/video/fbdev/68328fb.c
@@ -94,6 +94,7 @@ static int mc68x328fb_pan_display(struct fb_var_screeninfo *var,
 static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma);
 
 static const struct fb_ops mc68x328fb_ops = {
+	.owner		= THIS_MODULE,
 	.fb_check_var	= mc68x328fb_check_var,
 	.fb_set_par	= mc68x328fb_set_par,
 	.fb_setcolreg	= mc68x328fb_setcolreg,
-- 
2.40.0

[PATCH 2/3] fbdev/ps3fb: Init owner field of struct fb_ops

[Thomas Zimmermann]

Initialize the owner field of struct fb_ops. Required to prevent
module unloading while the driver is in use.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/ps3fb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/ps3fb.c b/drivers/video/fbdev/ps3fb.c
index 2fe08b67eda7..98aaa330a193 100644
--- a/drivers/video/fbdev/ps3fb.c
+++ b/drivers/video/fbdev/ps3fb.c
@@ -936,6 +936,7 @@ static irqreturn_t ps3fb_vsync_interrupt(int irq, void *ptr)
 
 
 static const struct fb_ops ps3fb_ops = {
+	.owner		= THIS_MODULE,
 	.fb_open	= ps3fb_open,
 	.fb_release	= ps3fb_release,
 	.fb_read        = fb_sys_read,
-- 
2.40.0

[PATCH 3/3] fbdev/vfb: Init owner field of struct fb_ops

[Thomas Zimmermann]

Initialize the owner field of struct fb_ops. Required to prevent
module unloading while the driver is in use.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/vfb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/vfb.c b/drivers/video/fbdev/vfb.c
index 680c88267ef4..a0a2009e003e 100644
--- a/drivers/video/fbdev/vfb.c
+++ b/drivers/video/fbdev/vfb.c
@@ -79,6 +79,7 @@ static int vfb_mmap(struct fb_info *info,
 		    struct vm_area_struct *vma);
 
 static const struct fb_ops vfb_ops = {
+	.owner		= THIS_MODULE,
 	.fb_read        = fb_sys_read,
 	.fb_write       = fb_sys_write,
 	.fb_check_var	= vfb_check_var,
-- 
2.40.0

Re: [PATCH 0/3] fbdev: Set missing owner fields in fb_ops

[Helge Deller]

On 4/24/23 10:58, Thomas Zimmermann wrote:
> Set the owner field of various drivers' fb_ops instance. The
> setting is required by fbcon, which acquires a reference on the
> fbdev driver's module. Otherwise, users could attempt to unload
> the module while it's still in use.
>
> Thomas Zimmermann (3):
>    fbdev/68328fb: Init owner field of struct fb_ops
>    fbdev/ps3fb: Init owner field of struct fb_ops
>    fbdev/vfb: Init owner field of struct fb_ops
>
>   drivers/video/fbdev/68328fb.c | 1 +
>   drivers/video/fbdev/ps3fb.c   | 1 +
>   drivers/video/fbdev/vfb.c     | 1 +
>   3 files changed, 3 insertions(+)
>

Series applied.

Thank you!
Helge