From: David Lechner <david@lechnology.com>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Invert margin colors when terminal is inverted
Date: Mon, 31 Jul 2017 20:43:38 +0000 [thread overview]
Message-ID: <80ad0768-069f-a7e7-2f4f-c0ed6b58b910@lechnology.com> (raw)
In-Reply-To: <20170731203025.6a59fdbd@alans-desktop>
On 07/31/2017 02:30 PM, Alan Cox wrote:
> On Mon, 31 Jul 2017 14:09:43 -0500
> David Lechner <david@lechnology.com> wrote:
>
>> This is v2 of "fbcon: Use background color for margins​"[1].
>>
>> It turns out that using the text background color was not a good choice. So,
>> I've started over.
>
> Can you explain why making the margins simply match the border colour
> (when possible) isn't a better option ? They are after all simply
> software extensions to the border.
>
So, basically, you are proposing that it would be better to add a module
parameter to select the margin color? That does sound like a better
option to me.
prev parent reply other threads:[~2017-07-31 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 19:09 [PATCH v2 0/2] Invert margin colors when terminal is inverted David Lechner
2017-07-31 19:09 ` [PATCH v2 1/2] fbcon: " David Lechner
2017-07-31 19:09 ` [PATCH v2 2/2] fbcon: add VT notifier for VT_UPDATE event David Lechner
2017-07-31 19:30 ` [PATCH v2 0/2] Invert margin colors when terminal is inverted Alan Cox
2017-07-31 20:43 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ad0768-069f-a7e7-2f4f-c0ed6b58b910@lechnology.com \
--to=david@lechnology.com \
--cc=b.zolnierkie@samsung.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).