From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E4FF483BFC for ; Mon, 21 Sep 2026 11:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789988801; cv=none; b=k7AR2UGlnSzdbvEHCE+uVvWvW3nvwi3CGHaH1cQLo+ONQzBEfCHizRGzUFand+ksCMedWzZ/aNdGOX6rC+pnQuxM5g4MDVxqJ95vkmoXw0mZopHfY0N/+c+lk3O4MaRerzC3nICSkhFTy5Dj57xZz6eA1GtzlMbakY/nu7RpgDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789988801; c=relaxed/simple; bh=APDQF13y/S2iTJC8bsCnwlXoIXm7Osc7h1xGKtGf/V8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GNf+PhdIfxOsRawSwMUgnNkriPOQXbsKKHd0tUdH41YJ/8+miey89ougpfj4xYO2exy8Vj/4Wa5dseq51SmF8JNgx+UiRKHwl3FqjOtym1lGsuVd9xaE86lUBGGTGz8MFexnAfsorhKsGV8icucRsnnjOo9FRb/X+3hswgbvL/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m8W0TYh/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=alIogjgH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m8W0TYh/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="alIogjgH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68LAeDQ6934672 for ; Mon, 21 Sep 2026 11:06:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fVGPjxP3QgcDv0E9g1JTcpUHcMxO88kzyAGTghYjz1g=; b=m8W0TYh/d0uyebaF /H4rugJm9UHLtaks3QckssiAtyDNBN4VuiPevXR9Djr6KzlTqNqN94dM756RqGU2 NScRNU1R8rw6V6EHlfnol+na3tTdTl+izaV+EApchomVaHSztCRB2Gr/yfhGRdnX Iz1Bxp3qr3rMUteI4SEwqtGKT37Qq1B4D4Fs+UTQiElzZQ3vjCBQAZXj5XYxb/3G bkbPenBi2YQVunoAyv1n8iI4d+obL17oNt7c5GmCUW68PrvRGh0SxpJtsQVzKsjI Qa7UIn7jbSnyIy5kiKVrb9zhBs1CubhRxIdm9WvcSkTT/EP958vHElgSm5C8lIy5 1aH33A== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gtq8ba9qa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 11:06:33 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5c665139c92so102298e0c.1 for ; Mon, 21 Sep 2026 04:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789988792; x=1790593592; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fVGPjxP3QgcDv0E9g1JTcpUHcMxO88kzyAGTghYjz1g=; b=alIogjgHTnDYsZU3X4O9nwBJ/dcD/mfTtZsWrYULgjIsTsd6y2XdOAywFhYu1Q43rH Ut4D/Xf2Uz7JJPv47oribEwHjtxtSOpi61ulaPFU8S/rWZLIUUWzMnRnCxy+2UlTu9tx 5Dnx3xEgcoxysDuQL4ewOQrY+I8aXbx3yhbZRe5IeyRX6M7fbaDjcpmT5WnZmuvNZWce B2rMPo5AI7szT2fiB3/62MCQftpEjMdBedvjt+epF4IEwmVhy48mI0jFIiJ+B/dellcN 030Uj6eSPwlnzM3rg50KwlronZggMmFNus1K6OyrQoZJ7PoE0VjPRErcmMK3L/Y2uG6E NgFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789988792; x=1790593592; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fVGPjxP3QgcDv0E9g1JTcpUHcMxO88kzyAGTghYjz1g=; b=GOm2Ju1TAK5YvhL1VWOGRtNkyTv056KuQhq+z14zwOQARzZRPImpBJ9FCOaZP49SWy TA5BY4QXx/ZWNat1dJYiVYvhMtODLgzHy0rYOKY0YPo2/nhcv8YPyuhytvk5jdxXkTqp 9uQYpS+vizCtgX+/JxikWqdHSqTcKdQYkQZy5yqYxpBODK2dZlQ3brtzQ9s2ak1CkIaz r3wpK8EddzZloWi6vElJdqv6aCdLr+EqFYsZxYYSYuY36WagHByhuJ+rR3umpTvDr+EF Mnxnn3Y/9p/u+hhH3xmKwsKpsj50Kl+YeGLiuTMKtHoMygnfuPen3+niKdMmXElnasFS EXRQ== X-Forwarded-Encrypted: i=1; AKwUvBwUXi3RAUoxm1E9C5qvzDiDGB/TzvncAfN9cLawumYcfafbPI53Z270wLQwF4APVMU0gSFHiERLZfB5Gw==@vger.kernel.org X-Gm-Message-State: AFuF++nyTAyQVloLXBReHbi+hdHvXKjv448iVfOWu26O+CWfvtAB95ek J0/31clbgfwO29z0BhCTy4viZhfgWlh3azglB4sn69Po35INaOsQw0CEEp7Q+Wf/uelKMXlbEgL ShyIcee7LOpztx9Q0BCO0sceG38bsBxN3RBdfzxVZxLxq/sttkAzHu+neGkRdJOVb6g== X-Gm-Gg: AYBFou2rmEFq/bR8nWtniBG+pZPh0rFUnNkGSACZgI13pXDXEqxcKjCaa2SIlbNC1Rt ygEM+R+FnQj7rlklnslSUUbbKBYxs+7Bz6mudytxysxsr97DMeG1npnRtXc43L6flkMbtdwZwsb XZ4XTIElSZeJAiNF2y77J5eOLzwODVLErCbSyy2giu0UDETo1a3uIzZlDTMVltywgtjVyS2jF0Q 2PmEWus+lf4uaNyf01klw2MFJcjx0MFJQVpgvDqTpkubU6bkYByU84aTcZJhv/pulBTEhJ5zAHW HwieOYE9fLPOxjpeH6nAgY+R095MKkdODehjhNL20Co2IdX3Snd2iCnR43wjd1P/MjWBIyHAmVj V3yX4gz1V/91d4jDZTxESwA== X-Received: by 2002:a05:6122:35c1:b0:5bf:b91f:3bb5 with SMTP id 71dfb90a1353d-5c9bc3b53e6mr3524543e0c.2.1789988792536; Mon, 21 Sep 2026 04:06:32 -0700 (PDT) X-Received: by 2002:a05:6122:35c1:b0:5bf:b91f:3bb5 with SMTP id 71dfb90a1353d-5c9bc3b53e6mr3524484e0c.2.1789988792144; Mon, 21 Sep 2026 04:06:32 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6aa67e1b7e1sm3810951a12.26.2026.09.21.04.06.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2026 04:06:31 -0700 (PDT) Message-ID: <8204dd54-d282-4303-85fb-d5408cc0b4b2@oss.qualcomm.com> Date: Mon, 21 Sep 2026 13:06:28 +0200 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] backlight: qcom-wled: Fix NULL pointer dereference in wled_remove() To: david@ixit.cz, Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Kiran Gunda , Marco Mattiolo , =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Joel Selvaraj , stable@vger.kernel.org References: <20260921-qcom-wled-backlight-v4-0-bab8c7ef73cb@ixit.cz> <20260921-qcom-wled-backlight-v4-1-bab8c7ef73cb@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260921-qcom-wled-backlight-v4-1-bab8c7ef73cb@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDE2MCBTYWx0ZWRfXy2UAOT9YX0UH 9SW8rh7xsc2V481F6wdr24LraSGUSZP6AvP/zJU0I3PTA8tz45Qbe8kMsXVZxx2G1hlo+6bb3NI +6IuhDlu34uSGlDxm91fhuow7cFw/WP0pMk7HF7/2J5QLEg0yTdDEnjSpHE7kMP9RMvbCkHAXOK bGuCaUFhhJvEb2uoH25IgeKQW3hnmehoSS5ab1t2UrHs1PnQrEJZNIVl+j4mOcB+QkVz75lIzlN usdXajcAdBDUdT9M5NNRRgOxliUP4vMKiyOTV7DPXMUiEmPyk32AIhujAOBE4M0zYtoDQByyJhO xUuFXJGLGlhPmTNd2gOXKvJJO8G7KEXYpOsyJTn370c3mNi31U6x6fbP1bNxS5Qfzz6FJx/dBsc W7/2n+hUrkXBNC2LhoxaoQ4hY8QjTS0obypKXuaSnGRVvV5t5tkyK9m8JYI8ZTrpyGEjmYx5Q/C lb/BbR154a7UgB6xmJA== X-Proofpoint-GUID: clMfMtuQHzM-YiWKkD_QWAWb4I3wlDRE X-Authority-Analysis: v=2.4 cv=T/8Z3PKQ c=1 sm=1 tr=0 ts=6ab10fb9 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=z8QxmeLbveigHahU524A:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-ORIG-GUID: clMfMtuQHzM-YiWKkD_QWAWb4I3wlDRE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDE2MCBTYWx0ZWRfXyFwlVcyLz/TJ UAY7yglpS9Sd7GwgRovVl01+ZuozxGweFNr5cOlYeZzROyPNYjj22IfDSah7736MzNQyNi4rg/q 3nOfnwwYHrp2b/vz23hoGOHSWcuYVpY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_04,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210160 On 9/21/26 12:46 PM, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > wled_probe() doesn't set the driver data for the platform device. > As a result, platform_get_drvdata() in wled_remove() will return NULL, > and the first dereference of it crashes on unbind. > > Set the platform device driver data in wled_probe(). > > Cc: stable@vger.kernel.org > Fixes: feeab87b3072 ("backlight: qcom-wled: Add support for short circuit handling") > Signed-off-by: David Heidelberg > --- Reviewed-by: Konrad Dybcio Konrad