From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: adaplas@pol.net
Cc: jsimmons@infradead.org,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BK FBDEV] A few more updates.
Date: Wed, 26 Mar 2003 11:53:24 +0100 [thread overview]
Message-ID: <85019355E7@vcnet.vc.cvut.cz> (raw)
On 26 Mar 03 at 11:42, Petr Vandrovec wrote:
>
> accel_cursor unconditionally sets FB_CUR_SETPOS. Can you write it
> down to the TODO list to eliminate this? Cursor position lives
> in different registers than cursor enable/disable on my hardware...
> And if we could rename FB_CUR_SETCUR to FB_CUR_SETVISIBILITY and
> leave cursor->enable setting on accel_cursor's caller, it would
> be even better.
I just noticed that softcursor.c contains copy of FB_CUR_SETCUR ->
cursor->enable code from accel_cursor(). Either 'enable' field has
no bussiness in the fb_cursor structure (as it can be always infered from
set flags, and if softcursor needs some internal bookkeeping, it should
use some other variable and not fb_cursor's field), or this conversion
should disappear from softcursor.c, and FB_CUR_SETCUR semantic should
change.
Petr
-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
next reply other threads:[~2003-03-26 10:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 10:53 Petr Vandrovec [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-03-26 10:42 [BK FBDEV] A few more updates Petr Vandrovec
2003-03-26 11:20 ` Antonino Daplas
2003-03-25 18:32 James Simmons
2003-03-25 18:01 ` Russell King
2003-03-25 18:28 ` Benjamin Herrenschmidt
2003-03-25 18:35 ` Benjamin Herrenschmidt
2003-03-25 19:48 ` James Simmons
2003-03-25 20:10 ` Benjamin Herrenschmidt
2003-03-25 20:14 ` James Simmons
2003-03-25 18:44 ` James Simmons
2003-03-26 3:37 ` Antonino Daplas
2003-03-26 5:34 ` James Simmons
2003-03-26 9:53 ` Antonino Daplas
2003-03-26 10:20 ` Antonino Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85019355E7@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=adaplas@pol.net \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).