From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Date: Fri, 03 Jun 2011 16:32:29 +0000 Subject: Re: [PATCH 01/27] OMAP: change get_context_loss_count ret value to int Message-Id: <871uzaj2oy.fsf@ti.com> List-Id: References: <1307095237-14805-1-git-send-email-tomi.valkeinen@ti.com> <1307095237-14805-2-git-send-email-tomi.valkeinen@ti.com> In-Reply-To: <1307095237-14805-2-git-send-email-tomi.valkeinen@ti.com> (Tomi Valkeinen's message of "Fri, 3 Jun 2011 13:00:11 +0300") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, b-cousson@ti.com, paul@pwsan.com Tomi Valkeinen writes: > get_context_loss_count functions return context loss count as u32, and > zero means an error. However, zero is also returned when context has > never been lost and could also be returned when the context loss count > has wrapped and goes to zero. > > Change the functions to return an int, with negative value meaning an > error. > > OMAP HSMMC code uses omap_pm_get_dev_context_loss_count(), but as the > hsmmc code handles the returned value as an int, with negative value > meaning an error, this patch actually fixes hsmmc code also. > > Signed-off-by: Tomi Valkeinen > Acked-by: Kevin Hilman This one should be separated out into a fix for v3.0-rc, and queued by Paul (also Cc'd to linux-arm-kernel.) Kevin