From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Sui Jingfeng <suijingfeng@loongson.cn>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Li Yi <liyi@loongson.cn>,
Christian Koenig <christian.koenig@amd.com>,
Helge Deller <deller@gmx.de>,
Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video/aperture: fix typos
Date: Tue, 04 Apr 2023 12:55:56 +0200 [thread overview]
Message-ID: <87355fex1f.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <0ad03743-0224-b154-a149-e3e4d54b252d@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
Hello Thomas,
Sorry, I just applied this patch and didn't see your email before...
> Hi
>
> Am 04.04.23 um 06:01 schrieb Sui Jingfeng:
>> EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer
>> driver.
>
> No whitespaces at the beginning of the lines.
>
I fixed that before applying, also removed the "are" in the sentence
above, since it sounded off and repharsed subject line as "Fix typos
in comments".
[...]
>> /*
>> * Remove the device from the device hierarchy. This is the right thing
>> - * to do for firmware-based DRM drivers, such as EFI, VESA or VGA. After
>> + * to do for firmware-based fb drivers, such as EFI, VESA or VGA. After
>
> That sentences is not well phrased. Maybe say 'This is required for
> firmware-provided graphics, such as EFI, VESA or VGA.'
>
Graphic drivers or display drivers would indeed be more accurate here. But
I think that "fb drivers" is still well pharsed since the are other places
where either fbdev or DRM drivers for firmware-provided framebuffers are
named like that.
For example, in the sysfb platform code and Kconfig symbol help text.
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-04-04 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 4:01 [PATCH] video/aperture: fix typos Sui Jingfeng
2023-04-04 10:05 ` Javier Martinez Canillas
2023-04-04 10:48 ` Javier Martinez Canillas
2023-04-04 10:41 ` Thomas Zimmermann
2023-04-04 10:55 ` Javier Martinez Canillas [this message]
2023-04-04 11:03 ` Javier Martinez Canillas
2023-04-05 9:55 ` Sui Jingfeng
2023-04-05 10:36 ` Sui Jingfeng
2023-04-04 11:08 ` Thomas Zimmermann
2023-05-12 15:09 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87355fex1f.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liyi@loongson.cn \
--cc=lucas.demarchi@intel.com \
--cc=mripard@kernel.org \
--cc=suijingfeng@loongson.cn \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).