From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1028EEB64DD for ; Tue, 25 Jul 2023 19:54:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjGYTyL (ORCPT ); Tue, 25 Jul 2023 15:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbjGYTyD (ORCPT ); Tue, 25 Jul 2023 15:54:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93E9719A1 for ; Tue, 25 Jul 2023 12:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690314799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/ehsQdgWSIS7eeNPhg1juxuHJiisqBuDA4AQKiM8tp4=; b=QY9NxMNp3iTsTIV05fwM9kHD9BftD8GRCqkUga4k2qLDEEoGlETcFgDARLNB8DDfGvC7l4 7Jn5a4dtqZXOEGif6Zu2sfYii9C6GwA7xNa7L2GvRS1KClY2UhjkEo/tS4xtffgIS5ATkp bOjimQ+lDHUxfrX+GvXsFwL6O8oXqT8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-3J8sVOlhOyuFtpLKtR5KrA-1; Tue, 25 Jul 2023 15:53:18 -0400 X-MC-Unique: 3J8sVOlhOyuFtpLKtR5KrA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30e4943ca7fso2838756f8f.3 for ; Tue, 25 Jul 2023 12:53:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690314797; x=1690919597; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ehsQdgWSIS7eeNPhg1juxuHJiisqBuDA4AQKiM8tp4=; b=k6rhSySQeiELzj5fjZGpJdj9BfdqpocZkmBjEiHs7KyNo7poiWM+b+FZGJZmLHt3jm tPgLpnPsyHVSXYZF6GtZmyDraZIONz6tvCLP5EIPCmhPOK3UjaP4k9WAbNDa5Qs8vJ5f X1tdOGS0+9DOtPcD0w7UwxTBumRizXJH5/10oEXQuII5dFsNLbthaW8PHCgI3z4jKw3S M4jT2dgzJKIYv5g5XmQHfEzryqr60Z6owSTEG40DcCBvG0mY8IOEQUibTzX7NQz7j6Zb xMexQ1Dv6jrH4t4oqWEIK+UXF6h5Pq2fWNHuzFkDfor5arO5itMjXZVM1PhALERHF/h+ mdnw== X-Gm-Message-State: ABy/qLZbYjtZzkux1QGjVTgVmAyYlqdONLNR12lLYtGjhW0uriE7FS15 fmbBTwek/NmMhw+yPi0EloQ7CSY/ut/237QufYxv3QV6KkEUm+2Vju0izEf+1ouUZgnzMXvswBY F4VHGw7sO1E7tUQWsI4A9h0vJDTB+9Es= X-Received: by 2002:a5d:4ccd:0:b0:313:e9dc:44d5 with SMTP id c13-20020a5d4ccd000000b00313e9dc44d5mr8756122wrt.61.1690314797299; Tue, 25 Jul 2023 12:53:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlEfpWWBSGVv7qsi/9x0G1/ru7iK4Zf2hflHhR0TYMahLeFmVnfj9mjTHzpX0KH0ux4gaM1qHQ== X-Received: by 2002:a5d:4ccd:0:b0:313:e9dc:44d5 with SMTP id c13-20020a5d4ccd000000b00313e9dc44d5mr8756108wrt.61.1690314796971; Tue, 25 Jul 2023 12:53:16 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id n15-20020a1c720f000000b003fc0505be19sm13825286wmc.37.2023.07.25.12.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 12:53:16 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , Geert Uytterhoeven Cc: Helge Deller , Arnd Bergmann , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: logo: LOGO should depend on FB_CORE i.s.o. FB In-Reply-To: References: <5ab3d1fe7b67ab10e4bc1bdbc0fa7731f7960965.1690300189.git.geert+renesas@glider.be> <87a5vkj7qe.fsf@minerva.mail-host-address-is-not-set> <877cqoj5q5.fsf@minerva.mail-host-address-is-not-set> Date: Tue, 25 Jul 2023 21:53:16 +0200 Message-ID: <874jlrkbtf.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Thomas Zimmermann writes: > Hi > [...] >> >> Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to >> source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends >> on FB_CORE. > > No, please rather leave it where it is. There's no code dependencies to > the fbdev core; it merely depends on the Kconfig token. > Sure, fine by me. But I disagree that there's merely a Kconfig dependency. The include/linux/linux_logo.h header declares both fb_find_logo() and fb_append_extra_logo(). The fb_find_logo() function is defined in drivers/video/logo.c while the fb_append_extra_logo() is in drivers/video/fbdev/core/fbmem.c, even though only arch/powerpc/platforms/cell/spu_base.c uses fb_append_extra_logo(). So there's a relationship already between logo and fbdev/core, that's why I wondered if would make sense to also move drivers/video/logo.c to have both functions in there. Yes, as noted drivers/video/console/newport_con.c also uses fb_find_logo() but the only other user of that in drivers/video/fbdev/core/fbmem.c. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat