[PATCH v2 1/2] dt-bindings: display: add devicetree bindings for pxa300-gcu

[PATCH v2 1/2] dt-bindings: display: add devicetree bindings for pxa300-gcu

[Daniel Mack]

This patch adds the binding documentation for the pxa300 gcu.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 .../bindings/display/marvell,pxa300-gcu.txt     | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt

diff --git a/Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt b/Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt
new file mode 100644
index 000000000000..9cfae5c4e8ec
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt
@@ -0,0 +1,17 @@
+PXA3xx GCU Controller
+---------------------
+
+Required properties:
+ - compatible : "marvell,pxa300-gcu"
+ - reg : should contain the register range (address and length).
+ - interrupts : Controller interrupt.
+ - clocks: phandle to the PXA specific input clock.
+
+Example for PXA300:
+
+	display-controller@54000000 {
+		compatible = "marvell,pxa300-gcu";
+		reg = <0x54000000 0x1000>;
+		interrupts = <39>;
+		clocks = <&clks CLK_PXA300_GCU>;
+	};
-- 
2.17.1

[PATCH v2 2/2] video: fbdev: pxa3xx_gcu: add devicetree bindings

[Daniel Mack]

Add a device tree match table for this hardware graphics acceleration
driver so it can be used by pxa3xx boards booted with a devicetree.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 drivers/video/fbdev/pxa3xx-gcu.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 0955622a1227..69cfb337c857 100644
--- a/drivers/video/fbdev/pxa3xx-gcu.c
+++ b/drivers/video/fbdev/pxa3xx-gcu.c
@@ -44,6 +44,7 @@
 #include <linux/clk.h>
 #include <linux/fs.h>
 #include <linux/io.h>
+#include <linux/of.h>
 
 #include "pxa3xx-gcu.h"
 
@@ -703,11 +704,20 @@ static int pxa3xx_gcu_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_OF
+static const struct of_device_id pxa3xx_gcu_of_match[] = {
+	{ .compatible = "marvell,pxa300-gcu", },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, pxa3xx_gcu_of_match);
+#endif
+
 static struct platform_driver pxa3xx_gcu_driver = {
 	.probe	  = pxa3xx_gcu_probe,
 	.remove	 = pxa3xx_gcu_remove,
 	.driver	 = {
 		.name   = DRV_NAME,
+		.of_match_table = of_match_ptr(pxa3xx_gcu_of_match),
 	},
 };
 
-- 
2.17.1

Re: [PATCH v2 2/2] video: fbdev: pxa3xx_gcu: add devicetree bindings

[Robert Jarzmik]

Daniel Mack <daniel@zonque.org> writes:

> Add a device tree match table for this hardware graphics acceleration
> driver so it can be used by pxa3xx boards booted with a devicetree.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

-- 
Robert

Re: [PATCH v2 2/2] video: fbdev: pxa3xx_gcu: add devicetree bindings

[Bartlomiej Zolnierkiewicz]

On Wednesday, July 04, 2018 09:35:02 PM Daniel Mack wrote:
> Add a device tree match table for this hardware graphics acceleration
> driver so it can be used by pxa3xx boards booted with a devicetree.
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>

Patch queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH v2 1/2] dt-bindings: display: add devicetree bindings for pxa300-gcu

[Rob Herring]

On Wed, Jul 04, 2018 at 09:35:01PM +0200, Daniel Mack wrote:
> This patch adds the binding documentation for the pxa300 gcu.
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---
>  .../bindings/display/marvell,pxa300-gcu.txt     | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 1/2] dt-bindings: display: add devicetree bindings for pxa300-gcu

[Daniel Mack]

Hi Bartlomiej,

On Wednesday, July 11, 2018 05:52 PM, Rob Herring wrote:
> On Wed, Jul 04, 2018 at 09:35:01PM +0200, Daniel Mack wrote:
>> This patch adds the binding documentation for the pxa300 gcu.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>> ---
>>   .../bindings/display/marvell,pxa300-gcu.txt     | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/display/marvell,pxa300-gcu.txt
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Can we take this through the pxa tree or do you want to merge it?


Thanks,
Daniel

Re: [PATCH v2 1/2] dt-bindings: display: add devicetree bindings for pxa300-gcu

[Bartlomiej Zolnierkiewicz]

On Wednesday, July 04, 2018 09:35:01 PM Daniel Mack wrote:
> This patch adds the binding documentation for the pxa300 gcu.
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>

Patch queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics