* Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed
2023-12-12 19:57 [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed Brian Masney
@ 2023-12-12 21:01 ` Andrew Halaney
2023-12-13 9:50 ` Javier Martinez Canillas
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Halaney @ 2023-12-12 21:01 UTC (permalink / raw)
To: Brian Masney
Cc: hdegoede, deller, treding, linux-fbdev, dri-devel, linux-kernel
On Tue, Dec 12, 2023 at 02:57:54PM -0500, Brian Masney wrote:
> When the power domains cannot be parsed, the message is incorrectly
> logged as an info message. Let's change this to an error since an error
> is returned.
>
> Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains")
> Signed-off-by: Brian Masney <bmasney@redhat.com>
Acked-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> drivers/video/fbdev/simplefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> index 6f58ee276ad1..028a56525047 100644
> --- a/drivers/video/fbdev/simplefb.c
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -470,7 +470,7 @@ static int simplefb_attach_genpds(struct simplefb_par *par,
> if (err == -ENOENT)
> return 0;
>
> - dev_info(dev, "failed to parse power-domains: %d\n", err);
> + dev_err(dev, "failed to parse power-domains: %d\n", err);
> return err;
> }
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed
2023-12-12 19:57 [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed Brian Masney
2023-12-12 21:01 ` Andrew Halaney
@ 2023-12-13 9:50 ` Javier Martinez Canillas
2023-12-13 11:42 ` Thierry Reding
2023-12-14 9:48 ` Hans de Goede
3 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2023-12-13 9:50 UTC (permalink / raw)
To: Brian Masney, hdegoede, deller
Cc: linux-fbdev, treding, linux-kernel, dri-devel
Brian Masney <bmasney@redhat.com> writes:
Hello Brian,
> When the power domains cannot be parsed, the message is incorrectly
> logged as an info message. Let's change this to an error since an error
> is returned.
>
> Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains")
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
> drivers/video/fbdev/simplefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> index 6f58ee276ad1..028a56525047 100644
> --- a/drivers/video/fbdev/simplefb.c
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -470,7 +470,7 @@ static int simplefb_attach_genpds(struct simplefb_par *par,
> if (err == -ENOENT)
> return 0;
>
> - dev_info(dev, "failed to parse power-domains: %d\n", err);
> + dev_err(dev, "failed to parse power-domains: %d\n", err);
> return err;
> }
>
Makes sense to me.
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed
2023-12-12 19:57 [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed Brian Masney
2023-12-12 21:01 ` Andrew Halaney
2023-12-13 9:50 ` Javier Martinez Canillas
@ 2023-12-13 11:42 ` Thierry Reding
2023-12-14 9:48 ` Hans de Goede
3 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2023-12-13 11:42 UTC (permalink / raw)
To: Brian Masney; +Cc: hdegoede, deller, linux-fbdev, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On Tue, Dec 12, 2023 at 02:57:54PM -0500, Brian Masney wrote:
> When the power domains cannot be parsed, the message is incorrectly
> logged as an info message. Let's change this to an error since an error
> is returned.
>
> Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains")
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
> drivers/video/fbdev/simplefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed
2023-12-12 19:57 [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed Brian Masney
` (2 preceding siblings ...)
2023-12-13 11:42 ` Thierry Reding
@ 2023-12-14 9:48 ` Hans de Goede
3 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2023-12-14 9:48 UTC (permalink / raw)
To: Brian Masney, deller; +Cc: treding, linux-fbdev, dri-devel, linux-kernel
Hi,
On 12/12/23 20:57, Brian Masney wrote:
> When the power domains cannot be parsed, the message is incorrectly
> logged as an info message. Let's change this to an error since an error
> is returned.
>
> Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains")
> Signed-off-by: Brian Masney <bmasney@redhat.com>
Thank you for your patch. I have pushed this to drm-misc-next now.
Regards,
Hans
> ---
> drivers/video/fbdev/simplefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> index 6f58ee276ad1..028a56525047 100644
> --- a/drivers/video/fbdev/simplefb.c
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -470,7 +470,7 @@ static int simplefb_attach_genpds(struct simplefb_par *par,
> if (err == -ENOENT)
> return 0;
>
> - dev_info(dev, "failed to parse power-domains: %d\n", err);
> + dev_err(dev, "failed to parse power-domains: %d\n", err);
> return err;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread