From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77973C83005 for ; Wed, 7 Jun 2023 07:37:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238932AbjFGHhZ (ORCPT ); Wed, 7 Jun 2023 03:37:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235322AbjFGHgg (ORCPT ); Wed, 7 Jun 2023 03:36:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD91A10CA for ; Wed, 7 Jun 2023 00:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686123340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rVXKtyFuQelZnCduaFGaTWYRY9d93/7uXkVVq77/kek=; b=NEdOoEY1XlXWuSNyuy2R/F8R32mZ0DffNcvocp3Chi1De58Mzsml5iaV94rpJhcBkuMedS mPzwX1FxrWhA5UhMO3BXLx1MIlP3p8pgq81JhkELxbXG8GWJvsE4hSK6mBDx+Bl8PgQO2/ tboREs3EoYfQ/y3tseICGNtlfYuwLnI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-vdmrTYE-NlGu_2QBKtkXvw-1; Wed, 07 Jun 2023 03:35:38 -0400 X-MC-Unique: vdmrTYE-NlGu_2QBKtkXvw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-30e3fb5d1a4so1498533f8f.3 for ; Wed, 07 Jun 2023 00:35:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686123337; x=1688715337; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rVXKtyFuQelZnCduaFGaTWYRY9d93/7uXkVVq77/kek=; b=XSALIwoQztGUFeVXm6/ClslwXFqVr6oDNZQ8xx4FL6i03Pa7Xx5EpnH5CW16zj0TvB gXuuXpgw+yJfsfSuKZrwlZimrNjYJb+j5te9tQYiLwx6ppeeMxIa1Juqk8g6yc+NV9al +5RhfaerijehZtzdfZUDYiyEpzyxya3vojWFLReziU4/Y4xWkXWqa4eYApzVlHkH2g3l qEfqym3RipPoontp1xbA/XLHx3KpJobyDpmYKlDNoL0jCcy5qEKYKdvlCKXbutP+Abxr JU8IhHUB65Py8FGQyJ5uXgyknCToOy9z0w91y+KvF/7zog0I/VlGWLCDLZOR76kJDb1V 5KKA== X-Gm-Message-State: AC+VfDw1naT2fDWtw5S2pwoMGe6QwVQqjzf3qIIUYoUW4F6B4+o44Z1j XmDHdWter/mwXLye3jLP6JQWLpJ6rZTsDgJTvdyCaf9mqt2Gp+twFxhqJidV1BqViBIa/JBRAMT ASZpmqCjJbyUqevaaZ7DeZr4= X-Received: by 2002:adf:e94c:0:b0:30e:3ccf:d4b1 with SMTP id m12-20020adfe94c000000b0030e3ccfd4b1mr3545210wrn.4.1686123337742; Wed, 07 Jun 2023 00:35:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7c4uJeHgefHAPZBCPOj0COJN3FPjwSoURcR8FFlOhwLdItHYCa5GZjGrjPHZg2iimtHbMokg== X-Received: by 2002:adf:e94c:0:b0:30e:3ccf:d4b1 with SMTP id m12-20020adfe94c000000b0030e3ccfd4b1mr3545188wrn.4.1686123337473; Wed, 07 Jun 2023 00:35:37 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id s15-20020a5d69cf000000b0030af31c8c63sm14618215wrw.47.2023.06.07.00.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 00:35:37 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , daniel@ffwll.ch, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com Cc: linux-fbdev@vger.kernel.org, Rich Felker , Yoshinori Sato , linux-sh@vger.kernel.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, Thomas Zimmermann , John Paul Adrian Glaubitz , linux-omap@vger.kernel.org Subject: Re: [PATCH 03/30] backlight/lv5207lp: Compare against struct fb_info.device In-Reply-To: <20230605144812.15241-4-tzimmermann@suse.de> References: <20230605144812.15241-1-tzimmermann@suse.de> <20230605144812.15241-4-tzimmermann@suse.de> Date: Wed, 07 Jun 2023 09:35:36 +0200 Message-ID: <875y7zhghj.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Thomas Zimmermann writes: > Struct lv5207lp_platform_data refers to a platform device within > the Linux device hierarchy. The test in lv5207lp_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device. > > Fixes a bug in the backlight driver and prepares fbdev for making > struct fb_info.dev optional. > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat