From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F53CA0ECA for ; Tue, 12 Sep 2023 07:56:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbjILH4W (ORCPT ); Tue, 12 Sep 2023 03:56:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231829AbjILH4Q (ORCPT ); Tue, 12 Sep 2023 03:56:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3C78EE73 for ; Tue, 12 Sep 2023 00:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694505325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x6EtKeJ8Fl2CPlsqoDZCiTeQu7RXnApXQXlT1M5EOII=; b=J5nmL6V/hmGD0bKhyRfqDeMcmPRAIheD9EPRrWXCz7V95RXjmzszmecTuYaNW+qXAG7Tk2 qgfC6aT1vmXCFmXGZVYB3HjYj1v/is3AT03VPatbslCmISl5Evbexz/hxJ74rTVNxZko88 Nj6gvmed23frS8jgNhIDlpW+dqIZhA8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-L1XcjiYxPvOu9ubAR3Ct8Q-1; Tue, 12 Sep 2023 03:55:23 -0400 X-MC-Unique: L1XcjiYxPvOu9ubAR3Ct8Q-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-401bdff6bc5so38420155e9.1 for ; Tue, 12 Sep 2023 00:55:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694505322; x=1695110122; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x6EtKeJ8Fl2CPlsqoDZCiTeQu7RXnApXQXlT1M5EOII=; b=cPrubyJcdp4RojT4VfFJ3zzaYbAPLh4Nl/E+9GCP/nmgnSr489Asmm6d+Pdi3wjylv UL5kItoNkdqMgqW6unSALME4OKhfXy7m0SIuJ3nV/gR6hTO4wr9EGqmAiDcaQyUqciBK hhh0F8kre34oLaFsx8C8tBSBOkpab2buz257OvocHFVqHUlCzDk/2lz4piemXt4/zy6l E8etnmWSkgR+bT2U2fSWsiTSXY24ZLvVTWXVhtiNR4NheGTPWm4OndQZWlGAbgKhH82l RS91W3TtEzxMizKeQzW1IgdwlUb2ekX4fuWWo4gft/0bcOFwlI8pvNJPpMwSbI5B9+lT qbOQ== X-Gm-Message-State: AOJu0Yyp8LnHh714hRuZ5bSgE7t/5cgQuJ9lSCtQz+jaT6coddTivQ0i bn3YbrB2/508xtZDjrpZ+uLecK8JFMh2bBCLMTaLjaq/7QbtQuSInquGuM/k6rrd0oW3EIcH4yg /CKMP16s71+KlLmyaiZhQsY0= X-Received: by 2002:a05:600c:2946:b0:3f9:c82e:9d87 with SMTP id n6-20020a05600c294600b003f9c82e9d87mr10082563wmd.13.1694505322759; Tue, 12 Sep 2023 00:55:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOUg/kbhGPkutoeBzAtzcpRlHWaTol5oRJ7Xvs/ofz8ZLVGBogom5lBgebkgCOX/YfVw74sw== X-Received: by 2002:a05:600c:2946:b0:3f9:c82e:9d87 with SMTP id n6-20020a05600c294600b003f9c82e9d87mr10082545wmd.13.1694505322409; Tue, 12 Sep 2023 00:55:22 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id p11-20020a1c740b000000b003ff013a4fd9sm12173082wmc.7.2023.09.12.00.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 00:55:22 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , Geert Uytterhoeven , Arnd Bergmann Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dave Airlie , Daniel Vetter , Greg Kroah-Hartman , Helge Deller , Christian =?utf-8?Q?K=C3=B6nig?= , Dave Airlie , Jim Cromie , Sam Ravnborg , Arthur Grillo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] drm: fix up fbdev Kconfig defaults In-Reply-To: References: <20230911205338.2385278-1-arnd@kernel.org> Date: Tue, 12 Sep 2023 09:55:21 +0200 Message-ID: <877cov3jx2.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org "Arnd Bergmann" writes: > On Tue, Sep 12, 2023, at 09:14, Geert Uytterhoeven wrote: >> On Mon, Sep 11, 2023 at 10:53=E2=80=AFPM Arnd Bergmann = wrote: [...] > > The only alternative I can think of would be to default-enable > or force-enable FRAMEBUFFER_CONSOLE for any config that includes > both VT_CONSOLE and FB_CORE. This would increase defconfig > builds for systems that currently only want CONFIG_FB for > either FB_DEVICE or LOGO but don't care about > FRAMEBUFFER_CONSOLE. I have no idea who uses such a config, > but I think Javier previously said this was an important > use case. > Yes, IMO that should be a possible combination. >>> diff --git a/drivers/video/fbdev/core/Kconfig b/drivers/video/fbdev/cor= e/Kconfig >>> index 114cb8aa6c8fd..804c2bec9b43c 100644 >>> --- a/drivers/video/fbdev/core/Kconfig >>> +++ b/drivers/video/fbdev/core/Kconfig >>> @@ -28,7 +28,7 @@ config FIRMWARE_EDID >>> config FB_DEVICE >>> bool "Provide legacy /dev/fb* device" >>> depends on FB_CORE >>> - default y >>> + default FB >> >> Changing this means possibly causing regressions on systems running >> an fbdev userspace. > > How? FB_DEVICE is a new config that was just split out from > CONFIG_FB in 6.6-rc1, so nobody should have any defconfig > that disables CONFIG_FB but relies on the FB_DEVICE default yet. > Ah, scratch my previous comment about making this default 'y' then. For some reasons I thought that FB_DEVICE was added in v6.5 but see now that commit 701d2054fa31 ("fbdev: Make support for userspace interfaces configurable") landed in v6.6-rc1: $ git tag --contains 701d2054fa31 | tail -1 v6.6-rc1 --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat