From: Jani Nikula <jani.nikula@intel.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Andy Walls <awalls@md.metrocast.net>,
Sakari Ailus <sakari.ailus@iki.fi>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 10/12] media: constify fb ops across all drivers
Date: Fri, 13 Dec 2019 10:41:33 +0000 [thread overview]
Message-ID: <87a77w33tu.fsf@intel.com> (raw)
In-Reply-To: <966b9db7-b6c2-d3a2-0842-574186418860@xs4all.nl>
On Thu, 12 Dec 2019, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 12/3/19 5:38 PM, Jani Nikula wrote:
>> Now that the fbops member of struct fb_info is const, we can start
>> making the ops const as well.
>>
>> Remove the redundant fbops assignments while at it.
>>
>> v2:
>> - actually add const in vivid
>> - fix typo (Christophe de Dinechin)
>>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>> Cc: Andy Walls <awalls@md.metrocast.net>
>> Cc: linux-media@vger.kernel.org
>> Cc: ivtv-devel@ivtvdriver.org
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Pushed to drm-misc-next, thanks for the reviews and acks.
BR,
Jani.
>
> Thanks!
>
> Hans
>
>> ---
>> drivers/media/pci/ivtv/ivtvfb.c | 3 +--
>> drivers/media/platform/vivid/vivid-osd.c | 3 +--
>> 2 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c
>> index 95a56cce9b65..f2922b554b09 100644
>> --- a/drivers/media/pci/ivtv/ivtvfb.c
>> +++ b/drivers/media/pci/ivtv/ivtvfb.c
>> @@ -925,7 +925,7 @@ static int ivtvfb_blank(int blank_mode, struct fb_info *info)
>> return 0;
>> }
>>
>> -static struct fb_ops ivtvfb_ops = {
>> +static const struct fb_ops ivtvfb_ops = {
>> .owner = THIS_MODULE,
>> .fb_write = ivtvfb_write,
>> .fb_check_var = ivtvfb_check_var,
>> @@ -1049,7 +1049,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)
>>
>> oi->ivtvfb_info.node = -1;
>> oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;
>> - oi->ivtvfb_info.fbops = &ivtvfb_ops;
>> oi->ivtvfb_info.par = itv;
>> oi->ivtvfb_info.var = oi->ivtvfb_defined;
>> oi->ivtvfb_info.fix = oi->ivtvfb_fix;
>> diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c
>> index f2e789bdf4a6..fbaec8acc161 100644
>> --- a/drivers/media/platform/vivid/vivid-osd.c
>> +++ b/drivers/media/platform/vivid/vivid-osd.c
>> @@ -244,7 +244,7 @@ static int vivid_fb_blank(int blank_mode, struct fb_info *info)
>> return 0;
>> }
>>
>> -static struct fb_ops vivid_fb_ops = {
>> +static const struct fb_ops vivid_fb_ops = {
>> .owner = THIS_MODULE,
>> .fb_check_var = vivid_fb_check_var,
>> .fb_set_par = vivid_fb_set_par,
>> @@ -311,7 +311,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)
>>
>> dev->fb_info.node = -1;
>> dev->fb_info.flags = FBINFO_FLAG_DEFAULT;
>> - dev->fb_info.fbops = &vivid_fb_ops;
>> dev->fb_info.par = dev;
>> dev->fb_info.var = dev->fb_defined;
>> dev->fb_info.fix = dev->fb_fix;
>>
>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2019-12-13 10:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 16:38 [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-12-03 16:38 ` [PATCH v3 01/12] video: fbdev: atyfb: modify the static fb_ops directly Jani Nikula
2019-12-03 16:46 ` Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 02/12] video: fbdev: mb862xx: " Jani Nikula
2019-12-03 16:50 ` Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 03/12] video: fbdev: nvidia: " Jani Nikula
2019-12-03 16:54 ` [Intel-gfx] " Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 04/12] video: fbdev: uvesafb: " Jani Nikula
2019-12-03 17:03 ` [Intel-gfx] " Daniel Vetter
2019-12-04 6:31 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 05/12] video: fbdev: make fbops member of struct fb_info a const pointer Jani Nikula
2019-12-05 0:12 ` kbuild test robot
2019-12-03 16:38 ` [PATCH v3 06/12] drm: constify fb ops across all drivers Jani Nikula
2019-12-03 16:38 ` [PATCH v3 07/12] video: fbdev: intelfb: use const pointer for fb_ops Jani Nikula
2019-12-03 17:09 ` Daniel Vetter
2019-12-03 16:38 ` [PATCH v3 08/12] video: constify fb ops across all drivers Jani Nikula
2019-12-05 9:37 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` [PATCH v3 09/12] HID: picoLCD: constify fb ops Jani Nikula
2019-12-09 13:59 ` [Intel-gfx] " Jani Nikula
2019-12-03 16:38 ` [PATCH v3 10/12] media: constify fb ops across all drivers Jani Nikula
2019-12-04 11:33 ` Sakari Ailus
2019-12-05 9:40 ` Jani Nikula
2019-12-12 9:02 ` Hans Verkuil
2019-12-13 10:41 ` Jani Nikula [this message]
2019-12-03 16:38 ` [PATCH v3 11/12] samples: vfio-mdev: constify fb ops Jani Nikula
2019-12-09 14:01 ` Jani Nikula
2019-12-09 18:55 ` Kirti Wankhede
2019-12-10 6:53 ` Jani Nikula
2019-12-03 16:38 ` [PATCH v3 12/12] auxdisplay: " Jani Nikula
2019-12-09 14:03 ` Jani Nikula
2019-12-10 19:08 ` Miguel Ojeda
2019-12-11 11:11 ` Jani Nikula
2019-12-11 8:35 ` robin
2019-12-03 16:42 ` [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a77w33tu.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=awalls@md.metrocast.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).