From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Date: Tue, 28 Apr 2015 19:35:12 +0000 Subject: Re: [PATCH v2 14/17] ARM: pxa: poodle: use new LoCoMo driver Message-Id: <87a8xsjbbj.fsf@belgarion.home> List-Id: References: <1430178954-11138-1-git-send-email-dbaryshkov@gmail.com> <1430178954-11138-15-git-send-email-dbaryshkov@gmail.com> In-Reply-To: <1430178954-11138-15-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Dmitry Eremin-Solenikov's message of "Tue, 28 Apr 2015 02:55:51 +0300") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dmitry Eremin-Solenikov Cc: Russell King , Daniel Mack , Linus Walleij , Alexandre Courbot , Wolfram Sang , Dmitry Torokhov , Bryan Wu , Richard Purdie , Samuel Ortiz , Lee Jones , Mark Brown , Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Liam Girdwood , Andrea Adami , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org Dmitry Eremin-Solenikov writes: > -#define POODLE_LOCOMO_GPIO_AMP_ON LOCOMO_GPIO(8) > -#define POODLE_LOCOMO_GPIO_MUTE_L LOCOMO_GPIO(10) > -#define POODLE_LOCOMO_GPIO_MUTE_R LOCOMO_GPIO(11) > -#define POODLE_LOCOMO_GPIO_232VCC_ON LOCOMO_GPIO(12) > -#define POODLE_LOCOMO_GPIO_JK_B LOCOMO_GPIO(13) > +#define POODLE_LOCOMO_GPIO_BASE (PXA_NR_BUILTIN_GPIO + 12) I missed that in the v1 serie : why twelve ? > +#define POODLE_GPIO_LCD_VSHA_ON (POODLE_LOCOMO_GPIO_BASE + 4) > +#define POODLE_GPIO_LCD_VSHD_ON (POODLE_LOCOMO_GPIO_BASE + 5) > +#define POODLE_GPIO_LCD_VEE_ON (POODLE_LOCOMO_GPIO_BASE + 6) > +#define POODLE_GPIO_LCD_MOD (POODLE_LOCOMO_GPIO_BASE + 7) > +#define POODLE_GPIO_AMP_ON (POODLE_LOCOMO_GPIO_BASE + 8) > +#define POODLE_GPIO_FL_VR (POODLE_LOCOMO_GPIO_BASE + 9) > +#define POODLE_GPIO_MUTE_L (POODLE_LOCOMO_GPIO_BASE + 10) > +#define POODLE_GPIO_MUTE_R (POODLE_LOCOMO_GPIO_BASE + 11) > +#define POODLE_GPIO_232VCC_ON (POODLE_LOCOMO_GPIO_BASE + 12) > +#define POODLE_GPIO_JK_B (POODLE_LOCOMO_GPIO_BASE + 13) Why not keep the LOCOMO_GPIO() defines, and redevice LOCOMO_GPIO(x) to (POODLE_LOCOMO_GPIO_BASE + (x)) ? No comments on the remaining part, as long as it's tested, you know me by now ... Cheers. -- Robert