From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFE1EB64D9 for ; Fri, 7 Jul 2023 15:28:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233335AbjGGP16 (ORCPT ); Fri, 7 Jul 2023 11:27:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232203AbjGGP14 (ORCPT ); Fri, 7 Jul 2023 11:27:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 080E62121 for ; Fri, 7 Jul 2023 08:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688743627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+8qlgKJYI7kB6D1e5SNd04VHZ2yM21oq3nfTt/gANL8=; b=Xp3V7QpxR0t4kn3riQcIygCunUkXwI6NZ3Tna1R1/eSSKIttUgnUBIEMa0bUEAsweRM2gc U6nnWomAy9UZxVmI7MDDjcPICPUqvUyj2cWWhWFPcUxqtL/gbiqKCzm2QxuPCdKnlNpwQG VW5QSR7ucZvmaJXYRS7+9Gx7xwPi09M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-1ka0aSOqOeGDzv_daYzX5w-1; Fri, 07 Jul 2023 11:27:05 -0400 X-MC-Unique: 1ka0aSOqOeGDzv_daYzX5w-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fc020021efso1292855e9.0 for ; Fri, 07 Jul 2023 08:27:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688743624; x=1691335624; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+8qlgKJYI7kB6D1e5SNd04VHZ2yM21oq3nfTt/gANL8=; b=RLU9U+8me+E/RN0C2MZ6P3HO3BBl13uKzFSiS7xiRd6g5uG/wZua/AHDQ0sXOqaf9u YuwSUuMoiuQLfmIgWqw5wf9gMB1aiPalEBdEN9mhCYwYGYpO223OpNiD+KuJKekq8etT CeyUFvvOtafqIol88tgd45BVC1gFsIkCqwV4RuuryonWkYemfoO31s7XSQNVUlAG44s1 hcn3Y4EEPOzBbECOGUXbi2GEgV+fBM9nweo3S5R2ZZkOQZ1ImN3H0YIJ3jEba2ZY1qBd 5nOO0NtTb5P23XWMO/qfJBbmmYP85FNSaq6SCTtqT7L+C933C+bw6bA07KkeizTNynjT 4EYA== X-Gm-Message-State: ABy/qLYWDmzf31C9+UHvAsjA/WtWfyJhdERK82Aj/VUtDWWubq7RGzym YrXt9pGdgWSOstgDNJx5tRql7LQNQsZtEEtJJGU3J1P5xesq8BGlFwLmqY0YzXj3rmAmb3wX1UB tgGRLE4Z+Dw+xq/EeHFsMUG0= X-Received: by 2002:adf:f052:0:b0:30a:a15d:eb2f with SMTP id t18-20020adff052000000b0030aa15deb2fmr4668093wro.3.1688743624749; Fri, 07 Jul 2023 08:27:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlGmxd1jbrrvV1R0iu/TeFKW/e1nuXfI0DnXijMIXAlyALphvzgzqltgfOe8J565vUOEzxyvoA== X-Received: by 2002:adf:f052:0:b0:30a:a15d:eb2f with SMTP id t18-20020adff052000000b0030aa15deb2fmr4668074wro.3.1688743624480; Fri, 07 Jul 2023 08:27:04 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id bl1-20020adfe241000000b003143c9beeaesm4711005wrb.44.2023.07.07.08.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 08:27:04 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , Arnd Bergmann , Thomas Zimmermann Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , dri-devel@lists.freedesktop.org, Ard Biesheuvel , Helge Deller , Greg Kroah-Hartman , Richard Henderson , Ivan Kokshaysky , Matt Turner , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 2/4] vgacon: rework screen_info #ifdef checks In-Reply-To: References: <20230707095415.1449376-1-arnd@kernel.org> <20230707095415.1449376-2-arnd@kernel.org> <87jzvbyh4p.fsf@minerva.mail-host-address-is-not-set> Date: Fri, 07 Jul 2023 17:27:03 +0200 Message-ID: <87bkgnyc6w.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org "Arnd Bergmann" writes: > On Fri, Jul 7, 2023, at 15:40, Javier Martinez Canillas wrote: [...] >> And this is only used by mdacon (not supported by ia64), vgacon and >> vga16fb (not supported by ia64 either). >> >> So this could just be guarded just by CONFIG_VGA_CONSOLE for ia64 ? > > Right, I though about doing this more accurately, but in the end > went for the simplest change rather than spending much more time > trying to clean up the unused variables etc. > > Let me know if you'd prefer me to respin this part, otherwise > I'd call the ia64 bit good enough for the purpose of the series. > No need to re-spin, agreed that makes sense to keep it simpler. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat