* [PATCH] fbdev/sh7760fb: allow modular build
@ 2024-02-10 5:39 Randy Dunlap
2024-02-10 8:25 ` Javier Martinez Canillas
2024-02-10 9:31 ` John Paul Adrian Glaubitz
0 siblings, 2 replies; 7+ messages in thread
From: Randy Dunlap @ 2024-02-10 5:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Geert Uytterhoeven, Thomas Zimmermann,
Javier Martinez Canillas, John Paul Adrian Glaubitz, Sam Ravnborg,
Helge Deller, linux-fbdev, dri-devel
There is no reason to prohibit sh7760fb from being built as a
loadable module as suggested by Geert, so change the config symbol
from bool to tristate to allow that and change the FB dependency as
needed.
Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
---
drivers/video/fbdev/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1645,8 +1645,8 @@ config FB_COBALT
select FB_IOMEM_HELPERS
config FB_SH7760
- bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
- depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
+ tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
+ depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
|| CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
select FB_IOMEM_HELPERS
help
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fbdev/sh7760fb: allow modular build
2024-02-10 5:39 [PATCH] fbdev/sh7760fb: allow modular build Randy Dunlap
@ 2024-02-10 8:25 ` Javier Martinez Canillas
2024-02-10 9:31 ` John Paul Adrian Glaubitz
1 sibling, 0 replies; 7+ messages in thread
From: Javier Martinez Canillas @ 2024-02-10 8:25 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Randy Dunlap, Geert Uytterhoeven, Thomas Zimmermann,
John Paul Adrian Glaubitz, Sam Ravnborg, Helge Deller,
linux-fbdev, dri-devel
Randy Dunlap <rdunlap@infradead.org> writes:
> There is no reason to prohibit sh7760fb from being built as a
> loadable module as suggested by Geert, so change the config symbol
> from bool to tristate to allow that and change the FB dependency as
> needed.
>
> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/video/fbdev/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fbdev/sh7760fb: allow modular build
2024-02-10 5:39 [PATCH] fbdev/sh7760fb: allow modular build Randy Dunlap
2024-02-10 8:25 ` Javier Martinez Canillas
@ 2024-02-10 9:31 ` John Paul Adrian Glaubitz
2024-04-10 4:54 ` Randy Dunlap
1 sibling, 1 reply; 7+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-02-10 9:31 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Geert Uytterhoeven, Thomas Zimmermann, Javier Martinez Canillas,
Sam Ravnborg, Helge Deller, linux-fbdev, dri-devel
On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
> There is no reason to prohibit sh7760fb from being built as a
> loadable module as suggested by Geert, so change the config symbol
> from bool to tristate to allow that and change the FB dependency as
> needed.
>
> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/video/fbdev/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1645,8 +1645,8 @@ config FB_COBALT
> select FB_IOMEM_HELPERS
>
> config FB_SH7760
> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
> select FB_IOMEM_HELPERS
> help
Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fbdev/sh7760fb: allow modular build
2024-02-10 9:31 ` John Paul Adrian Glaubitz
@ 2024-04-10 4:54 ` Randy Dunlap
2024-04-10 13:17 ` Helge Deller
2024-04-11 7:28 ` John Paul Adrian Glaubitz
0 siblings, 2 replies; 7+ messages in thread
From: Randy Dunlap @ 2024-04-10 4:54 UTC (permalink / raw)
To: John Paul Adrian Glaubitz, linux-kernel
Cc: Geert Uytterhoeven, Thomas Zimmermann, Javier Martinez Canillas,
Sam Ravnborg, Helge Deller, linux-fbdev, dri-devel
Hi,
Will someone be merging this patch?
thanks.
On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote:
> On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
>> There is no reason to prohibit sh7760fb from being built as a
>> loadable module as suggested by Geert, so change the config symbol
>> from bool to tristate to allow that and change the FB dependency as
>> needed.
>>
>> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Javier Martinez Canillas <javierm@redhat.com>
>> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: Helge Deller <deller@gmx.de>
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>> drivers/video/fbdev/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>> --- a/drivers/video/fbdev/Kconfig
>> +++ b/drivers/video/fbdev/Kconfig
>> @@ -1645,8 +1645,8 @@ config FB_COBALT
>> select FB_IOMEM_HELPERS
>>
>> config FB_SH7760
>> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
>> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
>> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
>> select FB_IOMEM_HELPERS
>> help
>
> Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>
> Adrian
>
--
#Randy
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fbdev/sh7760fb: allow modular build
2024-04-10 4:54 ` Randy Dunlap
@ 2024-04-10 13:17 ` Helge Deller
2024-04-11 7:32 ` John Paul Adrian Glaubitz
2024-04-11 7:28 ` John Paul Adrian Glaubitz
1 sibling, 1 reply; 7+ messages in thread
From: Helge Deller @ 2024-04-10 13:17 UTC (permalink / raw)
To: Randy Dunlap, John Paul Adrian Glaubitz, linux-kernel
Cc: Geert Uytterhoeven, Thomas Zimmermann, Javier Martinez Canillas,
Sam Ravnborg, linux-fbdev, dri-devel
On 4/10/24 06:54, Randy Dunlap wrote:
> Hi,
>
> Will someone be merging this patch?
I've just added it to the fbdev git tree.
Thanks!
Helge
>
> thanks.
>
> On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote:
>> On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
>>> There is no reason to prohibit sh7760fb from being built as a
>>> loadable module as suggested by Geert, so change the config symbol
>>> from bool to tristate to allow that and change the FB dependency as
>>> needed.
>>>
>>> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: Javier Martinez Canillas <javierm@redhat.com>
>>> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>> Cc: Helge Deller <deller@gmx.de>
>>> Cc: linux-fbdev@vger.kernel.org
>>> Cc: dri-devel@lists.freedesktop.org
>>> ---
>>> drivers/video/fbdev/Kconfig | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>>> --- a/drivers/video/fbdev/Kconfig
>>> +++ b/drivers/video/fbdev/Kconfig
>>> @@ -1645,8 +1645,8 @@ config FB_COBALT
>>> select FB_IOMEM_HELPERS
>>>
>>> config FB_SH7760
>>> - bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
>>> - depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>>> + tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
>>> + depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>>> || CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
>>> select FB_IOMEM_HELPERS
>>> help
>>
>> Acked-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>>
>> Adrian
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] fbdev/sh7760fb: allow modular build
2024-04-10 13:17 ` Helge Deller
@ 2024-04-11 7:32 ` John Paul Adrian Glaubitz
0 siblings, 0 replies; 7+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-04-11 7:32 UTC (permalink / raw)
To: Helge Deller, Randy Dunlap, linux-kernel
Cc: Geert Uytterhoeven, Thomas Zimmermann, Javier Martinez Canillas,
Sam Ravnborg, linux-fbdev, dri-devel
On Wed, 2024-04-10 at 15:17 +0200, Helge Deller wrote:
> On 4/10/24 06:54, Randy Dunlap wrote:
> > Hi,
> >
> > Will someone be merging this patch?
>
> I've just added it to the fbdev git tree.
Ah, good. Then I can drop it from my queue again.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fbdev/sh7760fb: allow modular build
2024-04-10 4:54 ` Randy Dunlap
2024-04-10 13:17 ` Helge Deller
@ 2024-04-11 7:28 ` John Paul Adrian Glaubitz
1 sibling, 0 replies; 7+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-04-11 7:28 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Geert Uytterhoeven, Thomas Zimmermann, Javier Martinez Canillas,
Sam Ravnborg, Helge Deller, linux-fbdev, dri-devel
Hi Randy,
On Tue, 2024-04-09 at 21:54 -0700, Randy Dunlap wrote:
> Will someone be merging this patch?
Shall I pick it up through my tree?
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-04-11 7:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-10 5:39 [PATCH] fbdev/sh7760fb: allow modular build Randy Dunlap
2024-02-10 8:25 ` Javier Martinez Canillas
2024-02-10 9:31 ` John Paul Adrian Glaubitz
2024-04-10 4:54 ` Randy Dunlap
2024-04-10 13:17 ` Helge Deller
2024-04-11 7:32 ` John Paul Adrian Glaubitz
2024-04-11 7:28 ` John Paul Adrian Glaubitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).