* [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'
@ 2018-10-16 7:59 YueHaibing
2018-10-16 23:52 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2018-10-16 7:59 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Daniel Vetter, Michael Ellerman,
Christophe Leroy
Cc: kernel-janitors, linux-fbdev, YueHaibing, dri-devel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init':
drivers/video/fbdev/chipsfb.c:352:22: warning:
variable 'size' set but not used [-Wunused-but-set-variable]
It not used any more after commit
8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/chipsfb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
index 40182ed..ca549e1 100644
--- a/drivers/video/fbdev/chipsfb.c
+++ b/drivers/video/fbdev/chipsfb.c
@@ -349,7 +349,7 @@ static void init_chips(struct fb_info *p, unsigned long addr)
static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
{
struct fb_info *p;
- unsigned long addr, size;
+ unsigned long addr;
unsigned short cmd;
int rc = -ENODEV;
@@ -361,7 +361,6 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
if ((dp->resource[0].flags & IORESOURCE_MEM) = 0)
goto err_disable;
addr = pci_resource_start(dp, 0);
- size = pci_resource_len(dp, 0);
if (addr = 0)
goto err_disable;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'
2018-10-16 7:59 [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size' YueHaibing
@ 2018-10-16 23:52 ` Michael Ellerman
2019-02-08 17:00 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2018-10-16 23:52 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Daniel Vetter, Christophe Leroy
Cc: kernel-janitors, linux-fbdev, YueHaibing, dri-devel
YueHaibing <yuehaibing@huawei.com> writes:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init':
> drivers/video/fbdev/chipsfb.c:352:22: warning:
> variable 'size' set but not used [-Wunused-but-set-variable]
>
> It not used any more after commit
> 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/video/fbdev/chipsfb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Looks good, thanks.
Should I merge this? Or otherwise:
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 40182ed..ca549e1 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -349,7 +349,7 @@ static void init_chips(struct fb_info *p, unsigned long addr)
> static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
> {
> struct fb_info *p;
> - unsigned long addr, size;
> + unsigned long addr;
> unsigned short cmd;
> int rc = -ENODEV;
>
> @@ -361,7 +361,6 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
> if ((dp->resource[0].flags & IORESOURCE_MEM) = 0)
> goto err_disable;
> addr = pci_resource_start(dp, 0);
> - size = pci_resource_len(dp, 0);
> if (addr = 0)
> goto err_disable;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'
2018-10-16 23:52 ` Michael Ellerman
@ 2019-02-08 17:00 ` Bartlomiej Zolnierkiewicz
2019-02-11 2:59 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-02-08 17:00 UTC (permalink / raw)
To: YueHaibing, Michael Ellerman, Christophe Leroy
Cc: Daniel Vetter, linux-fbdev, kernel-janitors, dri-devel
On 10/17/2018 01:52 AM, Michael Ellerman wrote:
> YueHaibing <yuehaibing@huawei.com> writes:
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init':
>> drivers/video/fbdev/chipsfb.c:352:22: warning:
>> variable 'size' set but not used [-Wunused-but-set-variable]
>>
>> It not used any more after commit
>> 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/video/fbdev/chipsfb.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Looks good, thanks.
>
> Should I merge this? Or otherwise:
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
I've queued the patch to fbdev tree for v5.1 w/ slightly modified patch
summary ("fbdev: chipsfb: ...") add patch description (use Fixes: tag),
thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'
2019-02-08 17:00 ` Bartlomiej Zolnierkiewicz
@ 2019-02-11 2:59 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2019-02-11 2:59 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, YueHaibing, Christophe Leroy
Cc: Daniel Vetter, linux-fbdev, kernel-janitors, dri-devel
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> writes:
> On 10/17/2018 01:52 AM, Michael Ellerman wrote:
>> YueHaibing <yuehaibing@huawei.com> writes:
>>
>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>
>>> drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init':
>>> drivers/video/fbdev/chipsfb.c:352:22: warning:
>>> variable 'size' set but not used [-Wunused-but-set-variable]
>>>
>>> It not used any more after commit
>>> 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK")
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>> drivers/video/fbdev/chipsfb.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> Looks good, thanks.
>>
>> Should I merge this? Or otherwise:
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> I've queued the patch to fbdev tree for v5.1 w/ slightly modified patch
> summary ("fbdev: chipsfb: ...") add patch description (use Fixes: tag),
> thanks.
Thanks.
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-11 2:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-16 7:59 [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size' YueHaibing
2018-10-16 23:52 ` Michael Ellerman
2019-02-08 17:00 ` Bartlomiej Zolnierkiewicz
2019-02-11 2:59 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).