Re: [PATCH v2 25/43] drm/ingenic: Use fbdev-dma

Paul Cercueil
2024-04-10T15:10:14Z

Le mercredi 10 avril 2024 à 15:02 +0200, Thomas Zimmermann a écrit :
> Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports
> damage handling, which is required by ingenic. Avoids the overhead of
> fbdev-generic's additional shadow buffering. No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Paul Cercueil <paul@crapouillou.net>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index 0751235007a7e..39fa291f43dd1 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -31,7 +31,7 @@
>  #include <drm/drm_encoder.h>
>  #include <drm/drm_gem_dma_helper.h>
>  #include <drm/drm_fb_dma_helper.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_dma.h>
>  #include <drm/drm_fourcc.h>
>  #include <drm/drm_framebuffer.h>
>  #include <drm/drm_gem_atomic_helper.h>
> @@ -1399,7 +1399,7 @@ static int ingenic_drm_bind(struct device *dev,
> bool has_components)
>   goto err_clk_notifier_unregister;
>   }
>
> - drm_fbdev_generic_setup(drm, 32);
> + drm_fbdev_dma_setup(drm, 32);
>
>   return 0;
>