Re: [PATCH v2 15/43] drm/tiny/gm12u320: Use fbdev-shmem

Hans de Goede
2024-04-10T13:20:30Z

Hi,

On 4/10/24 3:02 PM, Thomas Zimmermann wrote:
> Implement fbdev emulation with fbdev-shmem. Avoids the overhead of
> fbdev-generic's additional shadow buffering. No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Hans de Goede <hdegoede@redhat.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
> drivers/gpu/drm/tiny/gm12u320.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
> index 0187539ff5eaa..8b4efd39d7c41 100644
> --- a/drivers/gpu/drm/tiny/gm12u320.c
> +++ b/drivers/gpu/drm/tiny/gm12u320.c
> @@ -13,7 +13,7 @@
> #include <drm/drm_damage_helper.h>
> #include <drm/drm_drv.h>
> #include <drm/drm_edid.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_shmem.h>
> #include <drm/drm_file.h>
> #include <drm/drm_format_helper.h>
> #include <drm/drm_fourcc.h>
> @@ -699,7 +699,7 @@ static int gm12u320_usb_probe(struct usb_interface *interface,
> if (ret)
> goto err_put_device;
>
> - drm_fbdev_generic_setup(dev, 0);
> + drm_fbdev_shmem_setup(dev, 0);
>
> return 0;
>