From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
deller@gmx.de, daniel@ffwll.ch, sam@ravnborg.org,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH 3/7] fbdev/core: Fix style of code for boot-up logo
Date: Wed, 06 Sep 2023 11:59:37 +0200 [thread overview]
Message-ID: <87il8n4o6u.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20230829142109.4521-4-tzimmermann@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Fix a number of warnings from checkpatch.pl in this code before
> moving it into a separate file. This includes
>
> * Prefer 'unsigned int' to bare use of 'unsigned'
> * space required after that ',' (ctx:VxV)
> * space prohibited after that open parenthesis '('
> * suspect code indent for conditional statements (16, 32)
> * braces {} are not necessary for single statement blocks
>
> No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
[...]
> - static const unsigned char mask[] = { 0,0x80,0xc0,0xe0,0xf0,0xf8,0xfc,0xfe,0xff };
> + static const unsigned char mask[] = {
> + 0, 0x80, 0xc0, 0xe0, 0xf0, 0xf8, 0xfc, 0xfe, 0xff
> + };
I didn't know that checkpatch.pl complained about this.
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-09-06 10:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 14:15 [PATCH 0/7] fbdev: Split off code for boot-up logo Thomas Zimmermann
2023-08-29 14:15 ` [PATCH 1/7] fbdev/au1200fb: Do not display " Thomas Zimmermann
2023-09-06 9:45 ` Javier Martinez Canillas
2023-08-29 14:15 ` [PATCH 2/7] fbdev/mmp/mmpfb: " Thomas Zimmermann
2023-09-06 9:54 ` Javier Martinez Canillas
2023-09-07 6:56 ` Thomas Zimmermann
2023-08-29 14:15 ` [PATCH 3/7] fbdev/core: Fix style of code for " Thomas Zimmermann
2023-09-06 9:59 ` Javier Martinez Canillas [this message]
2023-08-29 14:15 ` [PATCH 4/7] fbdev/core: Move logo functions into separate source file Thomas Zimmermann
2023-08-29 15:55 ` kernel test robot
2023-09-01 20:09 ` kernel test robot
2023-09-01 20:20 ` kernel test robot
2023-09-06 10:10 ` Javier Martinez Canillas
2023-08-29 14:15 ` [PATCH 5/7] fbdev/core: Build fb_logo iff CONFIG_LOGO has been selected Thomas Zimmermann
2023-09-01 8:22 ` Helge Deller
2023-09-04 7:08 ` Thomas Zimmermann
2023-09-07 8:06 ` Thomas Zimmermann
2023-09-06 10:12 ` Javier Martinez Canillas
2023-09-07 8:07 ` Thomas Zimmermann
2023-08-29 14:15 ` [PATCH 6/7] fbdev/core: Remove empty internal helpers from fb_logo.c Thomas Zimmermann
2023-09-06 10:13 ` Javier Martinez Canillas
2023-08-29 14:15 ` [PATCH 7/7] fbdev/core: Clean up include statements in fbmem.c Thomas Zimmermann
2023-09-06 10:13 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il8n4o6u.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).