Re: [PATCH v5 2/4] fbdev: Move core fbdev symbols to a separate Kconfig file

[Javier Martinez Canillas <javierm@redhat.com>]

"Arnd Bergmann" <arnd@arndb.de> writes:

> On Fri, Jul 14, 2023, at 19:16, Javier Martinez Canillas wrote:
>> The drivers/video/fbdev/Kconfig defines both symbols for fbdev drivers and
>> core fbdev symbols, that can be enabled independently of the fbdev drivers.
>>
>> Split the Kconfig in two, one that only has the symbols for fbdev drivers
>> and another one that contains the fbdev core symbols.
>>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
>
> While testing this patch series, I noticed a conflict against
> Thomas Zimmermann's series for FB_SYS_HELPERS_DEFERRED, so you'll
> have to adapt the patches in order to apply them on top.
>

Indeed. That was my bad when doing the conflict resolution on rebase.

>> +
>> +config FB_HECUBA
>> +	tristate
>> +	depends on FB
>> +	depends on FB_DEFERRED_IO
>> +
>> +config FB_SVGALIB
>> +	tristate
>> +	depends on FB
>> +	help
>> +	  Common utility functions useful to fbdev drivers of VGA-based
>> +	  cards.
>> +
>> +config FB_MACMODES
>> +	tristate
>> +	depends on FB
>> +
>
> The FB_HECUBA now needs 'FB_SYS_HELPERS_DEFERRED' instead
> of 'FB_DEFERRED_IO', which is the change done in the other
> patch. I think the best way of doing that would be to just
> not move the three symbols above to core/Kconfig but leave them
> in place, as they are all just helper modules for some other
> drivers, rather than core code.
>

Agreed. I'll change that in v6 as well.

>       Arnd
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat