Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

[Javier Martinez Canillas <javierm@redhat.com>]

Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes:

Hello Miguel,

> On Sat, Jul 22, 2023 at 12:46 AM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>>
>> Javier Martinez Canillas <javierm@redhat.com> writes:
>>
>> [adding Miguel Ojeda who was not in the Cc list]
>>
>> Hello Miguel, could you please ack this patch so that I can take the whole
>> patch-set through the drm-misc tree?
>
> A note below...
>
>> > The drivers in this subsystem are for character-based LCD displays, which
>> > can fall into the same category of the DRM/KMS and fbdev drivers that are
>> > located under the "Graphics support" menu. Add auxdisplay there as well.
>
> Nit: this is not exactly true, e.g. ks0108/cfag12864b (which were the
> first in the subsystem) were not character-based but a very simple
> black-or-white 128x64 grid, so we should probably reword slightly
> this.
>

Oh, interesting. I wonder why that couldn't had been a fbdev driver then
using FB_VISUAL_MONO01? I'll reword then the commit message before apply
to the following instead:

"The drivers in this subsystem are for either character-based or monochrome
LCD controllers, which can fall into the same category of the DRM/KMS and
fbdev drivers, that are located under the "Graphics support" menu.

Add the auxdisplay drivers there as well to have all display drivers under
the same menu."

> In any case, if Helge thinks these may belong in the "Graphics
> support" menu, then I am fine with it:
>
>     Acked-by: Miguel Ojeda <ojeda@kernel.org>
>

Perfect, thanks!

> Thanks!
>
> Cheers,
> Miguel
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat