From: Peter Korsgaard <jacmet@sunsite.dk>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] video: da8xx-fb: add 24bpp LCD configuration support
Date: Wed, 18 Jul 2012 06:58:21 +0000 [thread overview]
Message-ID: <87mx2xv9ma.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1342590441-8441-1-git-send-email-prakash.pm@ti.com>
>>>>> "Prakash" = Manjunathappa, Prakash <prakash.pm@ti.com> writes:
Hi,
>> Personally I don't like, mix of "u32" and "unsigned int" declaration.
>>
Prakash> "unsigned int" is not guaranteed to be 32bit, may be "unsigned
Prakash> long" is better choice.
On the platforms where da8xx-fb is used it is.
>> > unsigned int palette_sz;
>> > unsigned int pxl_clk;
>> > int blank;
>> > @@ -546,6 +546,8 @@ static int lcd_cfg_frame_buffer(struct da8xx_fb_par *par, u32 width, u32 height,
>> > return 0;
>> > }
>> >
>> > +
>> > +#define CNVT_TOHW(val, width) ((((val)<<(width))+0x7FFF-(val))>>16)
>>
>> Did you run checkpatch.pl on this patch?
>>
Prakash> Yes, checkpatch.pl did not complain anything on this line. I
Prakash> will add space around binary operators.
An inline function would be nicer.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-07-18 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 5:59 [PATCH v2] video: da8xx-fb: add 24bpp LCD configuration support Manjunathappa, Prakash
2012-07-18 6:11 ` Hiremath, Vaibhav
2012-07-18 6:49 ` Manjunathappa, Prakash
2012-07-18 6:58 ` Peter Korsgaard [this message]
2012-07-18 7:00 ` Hiremath, Vaibhav
2012-07-18 9:44 ` Manjunathappa, Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx2xv9ma.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox