From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A39AEB64DA for ; Wed, 5 Jul 2023 09:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230157AbjGEJEM (ORCPT ); Wed, 5 Jul 2023 05:04:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbjGEJEL (ORCPT ); Wed, 5 Jul 2023 05:04:11 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A072710D5 for ; Wed, 5 Jul 2023 02:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688547804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rSX7qOujOrm27lX5ys/0lBz1p5bJBCSZMCXRlfpyvEg=; b=Q26ZwIhJ6DuOdfvKNzdxqgryMFUqoo+CKIj9fdTdQkSTfqsZRvSzhSGgBva2aCxqWfiu/W VykWv/d0I/iz+vm9kC5tfSsvCGEnazrSzNzD/KPNo8/2pG43sxoCcVuSwi/4yCnNt2qhCT FaKdI1/Zna7r9WnrNGxQdR4iqZXdbqQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-qsvvtotMOnmHxu6GMTgxgw-1; Wed, 05 Jul 2023 05:03:23 -0400 X-MC-Unique: qsvvtotMOnmHxu6GMTgxgw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fbaade0c71so40334415e9.2 for ; Wed, 05 Jul 2023 02:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688547802; x=1691139802; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rSX7qOujOrm27lX5ys/0lBz1p5bJBCSZMCXRlfpyvEg=; b=JnRKakkZJDI/l40w2+J3aN+UrBqf3OsVEbZ7YSyVIIurtNfeMzt2F3BhqBaeKi1uo1 wfqssxp0/UEffFWM45GxEVKZDl2bK2SKuXIb3gE0L4JWWUvyz8h9Jrv9EOD0lWtEyJ4K aV7TaFQTp1c2jxe8HPspI7zGpVRQPqWsGBi29394+TaxPmA5H7yxzEka1RG2P4281C8S d5MPIV4G9/a2Za/j8V0afccMWcouqmLd3LaNehOIUcLkZXlYGAQYmEfxMGvLhu2EiCVe BnBTL7inNto3g4lgOKzi58R6aaZiajKYF0vrUlhlHT7LeSCHjDdQ7BX9VnrnGx0NcO5t p/ig== X-Gm-Message-State: AC+VfDxeKG7Lb2YFsuMd0BPNzfmWDy8EUoY77AMsGc3YcqofRgj3B51K 9mhxE1z4traCH7mtG7AZZn8ZMWOTH/VN2ntMhk91WP26ehGEsuW8gCtzKyGPTCIvQ/2Ba58H3yo 76qIDdy3p46b5Oxd+UHKdTjI= X-Received: by 2002:a1c:f314:0:b0:3fb:adc0:609b with SMTP id q20-20020a1cf314000000b003fbadc0609bmr14653347wmq.13.1688547802463; Wed, 05 Jul 2023 02:03:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4D75aEjUYAXwEsqp9EVXq6EMXjhrEVDhsSnE0141Cb1WbjzG1CyfPykxapyYpYnd68hWU11g== X-Received: by 2002:a1c:f314:0:b0:3fb:adc0:609b with SMTP id q20-20020a1cf314000000b003fbadc0609bmr14653330wmq.13.1688547802102; Wed, 05 Jul 2023 02:03:22 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id m11-20020a7bce0b000000b003f90b9b2c31sm1507833wmc.28.2023.07.05.02.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 02:03:21 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Tomi Valkeinen Subject: Re: [PATCH 07/10] drm/omapdrm: Set VM flags in GEM-object mmap function In-Reply-To: <20230704160133.20261-8-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-8-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 11:03:21 +0200 Message-ID: <87o7kqraqu.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Thomas Zimmermann writes: > Use the mmap callback in struct drm_gem_object_funcs to set the > VM flags. Replace a number of mmap helpers in omapdrm with their > GEM helper counterparts. Generate DRM's file-operations instance > with GEM's DEFINE_DRM_GEM_FOPS. > > Signed-off-by: Thomas Zimmermann > Cc: Tomi Valkeinen > --- > +static int omap_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) > { > struct omap_gem_object *omap_obj = to_omap_bo(obj); > > - vm_flags_mod(vma, VM_MIXEDMAP, VM_PFNMAP); > + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP | VM_IO | VM_MIXEDMAP); > > if (omap_obj->flags & OMAP_BO_WC) { > vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); > @@ -563,12 +548,14 @@ int omap_gem_mmap_obj(struct drm_gem_object *obj, > * address_space (so unmap_mapping_range does what we want, > * in particular in the case of mmap'd dmabufs) > */ > - vma->vm_pgoff = 0; > + vma->vm_pgoff -= drm_vma_node_start(&obj->vma_node); > vma_set_file(vma, obj->filp); > > vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > } > > + vma->vm_page_prot = pgprot_decrypted(vma->vm_page_prot); > + > return 0; > } > I think this rework deserves a more elaborated commit message. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat