From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
linux-fbdev@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
devel@linuxdriverproject.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH 2/3 v3] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type
Date: Thu, 29 Jan 2015 13:02:09 +0000 [thread overview]
Message-ID: <87oaph7nam.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <1422527056-24929-1-git-send-email-der.herr@hofr.at> (Nicholas Mc Guire's message of "Thu, 29 Jan 2015 11:24:16 +0100")
Nicholas Mc Guire <der.herr@hofr.at> writes:
> The return type of wait_for_completion_timeout is unsigned long not
> int. This patch fixes up the declarations only.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
I would be slightly better to remove ".c" from your subject like,
anyway:
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
>
> v2: fixed subject line
> v3: fixed patch description as recommended by Dan Carpenter
> <dan.carpenter@oracle.com>
>
> Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y
> CONFIG_HYPERV=m, CONFIG_FB_HYPERV=m
>
> Patch is against 3.19.0-rc5 -next-20150123
>
> drivers/video/fbdev/hyperv_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
> index 4254336..807ee22 100644
> --- a/drivers/video/fbdev/hyperv_fb.c
> +++ b/drivers/video/fbdev/hyperv_fb.c
> @@ -415,7 +415,8 @@ static int synthvid_negotiate_ver(struct hv_device *hdev, u32 ver)
> struct fb_info *info = hv_get_drvdata(hdev);
> struct hvfb_par *par = info->par;
> struct synthvid_msg *msg = (struct synthvid_msg *)par->init_buf;
> - int t, ret = 0;
> + int ret = 0;
> + unsigned long t;
>
> memset(msg, 0, sizeof(struct synthvid_msg));
> msg->vid_hdr.type = SYNTHVID_VERSION_REQUEST;
> @@ -488,7 +489,8 @@ static int synthvid_send_config(struct hv_device *hdev)
> struct fb_info *info = hv_get_drvdata(hdev);
> struct hvfb_par *par = info->par;
> struct synthvid_msg *msg = (struct synthvid_msg *)par->init_buf;
> - int t, ret = 0;
> + int ret = 0;
> + unsigned long t;
>
> /* Send VRAM location */
> memset(msg, 0, sizeof(struct synthvid_msg));
--
Vitaly
next prev parent reply other threads:[~2015-01-29 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 10:24 [PATCH 2/3 v3] hyperv: hyperv_fb.c: match wait_for_completion_timeout return type Nicholas Mc Guire
2015-01-29 13:02 ` Vitaly Kuznetsov [this message]
2015-03-10 12:38 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaph7nam.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=der.herr@hofr.at \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).