From: Jani Nikula <jani.nikula@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
mpe@ellerman.id.au, naresh.kamboju@linaro.org, deller@gmx.de,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
lkft-triage@lists.linaro.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v2 2/3] macintosh/via-pmu-backlight: Include <linux/backlight.h>
Date: Tue, 05 Mar 2024 11:13:20 +0200 [thread overview]
Message-ID: <87plw92g9b.fsf@intel.com> (raw)
In-Reply-To: <20240305090910.26742-3-tzimmermann@suse.de>
On Tue, 05 Mar 2024, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the
> backlight header has recently been removed from <linux/fb.h>. Add it to
> via-pmu-backlight.c to get the necessary symbols.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com/
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/macintosh/via-pmu-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
> index c2d87e7fa85be..89450645c2305 100644
> --- a/drivers/macintosh/via-pmu-backlight.c
> +++ b/drivers/macintosh/via-pmu-backlight.c
> @@ -10,6 +10,7 @@
>
> #include <asm/ptrace.h>
> #include <linux/adb.h>
> +#include <linux/backlight.h>
> #include <linux/pmu.h>
> #include <asm/backlight.h>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-03-05 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 9:00 [PATCH v2 0/3] arch/powerpc: Resolve backlight include dependencies Thomas Zimmermann
2024-03-05 9:00 ` [PATCH v2 1/3] fbdev/chipsfb: Include <linux/backlight.h> Thomas Zimmermann
2024-03-05 9:00 ` [PATCH v2 2/3] macintosh/via-pmu-backlight: " Thomas Zimmermann
2024-03-05 9:13 ` Jani Nikula [this message]
2024-03-05 9:01 ` [PATCH v2 3/3] arch/powerpc: Remove <linux/fb.h> from backlight code Thomas Zimmermann
2024-03-05 9:15 ` Jani Nikula
2024-03-05 9:25 ` Christophe Leroy
2024-03-05 10:04 ` Thomas Zimmermann
2024-03-05 10:06 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plw92g9b.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mpe@ellerman.id.au \
--cc=naresh.kamboju@linaro.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).