* [PATCH v2] video: logo: LOGO should depend on FB_CORE i.s.o. FB
@ 2023-07-28 9:21 Geert Uytterhoeven
2023-07-28 10:03 ` Javier Martinez Canillas
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2023-07-28 9:21 UTC (permalink / raw)
To: Helge Deller, Javier Martinez Canillas, Arnd Bergmann
Cc: linux-fbdev, dri-devel, linux-kernel, Geert Uytterhoeven
If CONFIG_FB_CORE=y and CONFIG_FB=n, the frame buffer bootup logos can
no longer be enabled. Fix this by making CONFIG_LOGO depend on
CONFIG_FB_CORE instead of CONFIG_FB, as there is no good reason for the
logo code to depend on the presence of real frame buffer device drivers.
Fixes: 55bffc8170bb5813 ("fbdev: Split frame buffer support in FB and FB_CORE symbols")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
v2:
- Add Reviewed-by.
---
drivers/video/Kconfig | 2 +-
drivers/video/logo/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index e5b1cc54cafa10d5..b694d7669d3200b1 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -63,7 +63,7 @@ if VT
source "drivers/video/console/Kconfig"
endif
-if FB || SGI_NEWPORT_CONSOLE
+if FB_CORE || SGI_NEWPORT_CONSOLE
source "drivers/video/logo/Kconfig"
endif
diff --git a/drivers/video/logo/Kconfig b/drivers/video/logo/Kconfig
index 6d6f8c08792dc897..b7d94d1dd1585a84 100644
--- a/drivers/video/logo/Kconfig
+++ b/drivers/video/logo/Kconfig
@@ -5,7 +5,7 @@
menuconfig LOGO
bool "Bootup logo"
- depends on FB || SGI_NEWPORT_CONSOLE
+ depends on FB_CORE || SGI_NEWPORT_CONSOLE
help
Enable and select frame buffer bootup logos.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] video: logo: LOGO should depend on FB_CORE i.s.o. FB
2023-07-28 9:21 [PATCH v2] video: logo: LOGO should depend on FB_CORE i.s.o. FB Geert Uytterhoeven
@ 2023-07-28 10:03 ` Javier Martinez Canillas
0 siblings, 0 replies; 2+ messages in thread
From: Javier Martinez Canillas @ 2023-07-28 10:03 UTC (permalink / raw)
To: Geert Uytterhoeven, Helge Deller, Arnd Bergmann
Cc: linux-fbdev, dri-devel, linux-kernel, Geert Uytterhoeven
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> If CONFIG_FB_CORE=y and CONFIG_FB=n, the frame buffer bootup logos can
> no longer be enabled. Fix this by making CONFIG_LOGO depend on
> CONFIG_FB_CORE instead of CONFIG_FB, as there is no good reason for the
> logo code to depend on the presence of real frame buffer device drivers.
>
> Fixes: 55bffc8170bb5813 ("fbdev: Split frame buffer support in FB and FB_CORE symbols")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-28 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 9:21 [PATCH v2] video: logo: LOGO should depend on FB_CORE i.s.o. FB Geert Uytterhoeven
2023-07-28 10:03 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).