From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Daniel Thompson <daniel.thompson@linaro.org>,
Andrea Adami <andrea.adami@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] backlight: tdo24m: fix the spi cs between transfers
Date: Mon, 09 Oct 2017 18:30:13 +0000 [thread overview]
Message-ID: <87tvz8dvii.fsf@belgarion.home> (raw)
In-Reply-To: <0ee32bde-0f3b-52b2-965f-84fa017c7b16@linaro.org> (Daniel Thompson's message of "Mon, 9 Oct 2017 12:14:38 +0100")
Daniel Thompson <daniel.thompson@linaro.org> writes:
> On 06/10/17 20:58, Robert Jarzmik wrote:
>
> I'm a tiny bit worried about see-saw bug fixing here but nevertheless this
> change looks correct to me.
>
> Mike's change was eight years ago and it is reasonable to hope that the patch
> was really just working around a (hopefully long fixed) bug in the SPI driver!
Actually I think it's the case.
And the driver bug fix is here :
a52db659c79c ("spi: pxa2xx: Fix cs_change management")
And please don't apply this as there are 2 other LCDs which are affected by the
same issue and reported by Andrea, for which I had not correlated the issue
until yesterday, so I'll have to respin this 2 others files, namely :
- drivers/video/backlight/corgi_lcd.c.
- drivers/video/backlight/tosa_lcd.c.
There 2 other candidates I won't touch as they are not under my maintainance,
and I have no way to test them :
- ili922x.c
- ltv350qv.c
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Thanks, but there will be a v2 with exactly the same fix in 3 files.
Cheers.
--
Robert
prev parent reply other threads:[~2017-10-09 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 19:58 [PATCH 1/3] backlight: tdo24m: fix the spi cs between transfers Robert Jarzmik
2017-10-06 19:58 ` [PATCH 2/3] backlight: tdo24m: add the reset line gpio Robert Jarzmik
2017-10-06 19:58 ` [PATCH 3/3] backlight: tdo24m: add model and status sysfs entries Robert Jarzmik
2017-10-09 11:14 ` [PATCH 1/3] backlight: tdo24m: fix the spi cs between transfers Daniel Thompson
2017-10-09 18:30 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvz8dvii.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=andrea.adami@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox