From: Javier Martinez Canillas <javierm@redhat.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Helge Deller <deller@gmx.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jilin Yuan <yuanjilin@cdjrlc.com>,
linux-fbdev@vger.kernel.org, kernel@pengutronix.de,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] video: fbdev: ssd1307fb: Print the PWM's label instead of its number
Date: Sun, 10 Sep 2023 08:58:27 +0200 [thread overview]
Message-ID: <87v8ciikfg.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20230909202110.bcz5qvb7bfrzco73@pengutronix.de>
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
Hello Uwe,
> Hello,
>
> On Sat, Sep 09, 2023 at 04:38:28PM +0200, Javier Martinez Canillas wrote:
>> Javier Martinez Canillas <javierm@redhat.com> writes:
>>
>> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
>> >
>> >> struct pwm_device::pwm is a write-only variable in the pwm core and used
>> >> nowhere apart from this and another dev_dbg. So it isn't useful to
>> >> identify the used PWM. Emit the PWM's label instead in the debug
>> >> message.
>> >>
>> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> >> ---
>> >
>> > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>> >
>>
>> Pushed to drm-misc (drm-misc-next). Thanks!
>
> JFTR: This patch is already in linus/master. And Javier pushed
> "drm/ssd130x: Print the PWM's label instead of its number" to
> drm-misc-next which is great. So the "Pushed to ..." mail is just in
> reply to the wrong patch in this thread and in git everything is fine.
>
Ups, that's correct. Thanks a lot for pointing that out!
> Thanks
> Uwe
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-09-10 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:58 [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device Uwe Kleine-König
2023-07-28 14:58 ` [PATCH 2/3] video: fbdev: ssd1307fb: Print the PWM's label instead of its number Uwe Kleine-König
2023-07-28 15:40 ` Javier Martinez Canillas
2023-09-09 14:38 ` Javier Martinez Canillas
2023-09-09 20:21 ` Uwe Kleine-König
2023-09-10 6:58 ` Javier Martinez Canillas [this message]
2023-07-31 12:42 ` Helge Deller
2023-08-01 8:54 ` Andy Shevchenko
2023-11-13 21:28 ` [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8ciikfg.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).