From: Javier Martinez Canillas <javierm@redhat.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 5/8] video/aperture: Move vga handling to pci function
Date: Wed, 05 Apr 2023 13:34:01 +0200 [thread overview]
Message-ID: <87v8iabm1i.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20230404201842.567344-5-daniel.vetter@ffwll.ch>
Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> A few reasons for this:
>
> - It's really the only one where this matters. I tried looking around,
> and I didn't find any non-pci vga-compatible controllers for x86
> (since that's the only platform where we had this until a few
> patches ago), where a driver participating in the aperture claim
> dance would interfere.
>
> - I also don't expect that any future bus anytime soon will
> not just look like pci towards the OS, that's been the case for like
> 25+ years by now for practically everything (even non non-x86).
>
> - Also it's a bit funny if we have one part of the vga removal in the
> pci function, and the other in the generic one.
>
> v2: Rebase.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/aperture.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-04-05 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230404201842.567344-1-daniel.vetter@ffwll.ch>
2023-04-04 20:18 ` [PATCH 2/8] video/aperture: use generic code to figure out the vga default device Daniel Vetter
2023-04-05 11:27 ` Javier Martinez Canillas
2023-04-04 20:18 ` [PATCH 3/8] drm/aperture: Remove primary argument Daniel Vetter
2023-04-04 21:20 ` Martin Blumenstingl
2023-04-05 9:25 ` Thierry Reding
2023-04-05 11:30 ` Javier Martinez Canillas
2023-04-04 20:18 ` [PATCH 4/8] video/aperture: Only kick vgacon when the pdev is decoding vga Daniel Vetter
2023-04-05 11:31 ` Javier Martinez Canillas
2023-04-04 20:18 ` [PATCH 5/8] video/aperture: Move vga handling to pci function Daniel Vetter
2023-04-05 11:34 ` Javier Martinez Canillas [this message]
2023-04-04 20:18 ` [PATCH 6/8] video/aperture: Drop primary argument Daniel Vetter
2023-04-05 11:36 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8iabm1i.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox