From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LKXPr3po" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECD1187 for ; Thu, 16 Nov 2023 03:26:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700133988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xhfIum68/LfGGlKZxKOpUyUVoYt3PypwKYYqLYNBIe4=; b=LKXPr3poCS0Jvwqk31sYxbtX4gHmsXQ3+H40DISKO50Nw/5togLZ4lN4mw2tZan/tG2eVV KVz8sT1jSe/FivlukqSx7fLktEbrzfA9mXZb5oTTrGkVnBvIjJ0QREVE/rDoUwUecIJm7e E8QZPQzmYGerQJbzB7C220J6lXfVBtA= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-9Yn46j9GPGavzw3y1BPfyg-1; Thu, 16 Nov 2023 06:26:27 -0500 X-MC-Unique: 9Yn46j9GPGavzw3y1BPfyg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c50bebd8dfso5924101fa.3 for ; Thu, 16 Nov 2023 03:26:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700133985; x=1700738785; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xhfIum68/LfGGlKZxKOpUyUVoYt3PypwKYYqLYNBIe4=; b=jooGRdvhQaQDaUdhmu2MBG20VxKzZK/WIURPydBwhJbRnE3usARAeMfTNY4hakXppk xM9utErN+7gBWNPhdlYag1NBXuK5+BrnkxePEYmDcQuSvx/QEAnxL8xOgsUy1zL+gnqh 8YOSCO0+vcRdBE9cOx7kTZzvNvLPlGiR3AJGXqeFsDc7VuLkf4kR7TInmkO70hgrdEzk wWQ3dLIY9n6NoTzXZs4jSKCYO0c/HQ1X+PbvA35AYnCpp81LDvgnQ6HARV9VwCYE+Uiy Vxl6YZd0x+XWR4l33VKJM8SWu9NfJjDb42eAKmtVhFGOFbdicHTrDym1px806yA498dQ OGUw== X-Gm-Message-State: AOJu0Yz67TJ4uZcCdhpE9SJFMP08LsxE2B1k+EtcRSvFNCu4jkN6Li0/ zGzpMgV05dY7pqEmmCmijrW2JIAfHY8qGbaZDIWcAiBWVKw+zG4OcDrv2F1/i/zrhxo8ntiv0UY ncOlL5lHGQ5UkLETCGU/cEk4= X-Received: by 2002:a2e:a4cb:0:b0:2c5:5926:de52 with SMTP id p11-20020a2ea4cb000000b002c55926de52mr5121265ljm.53.1700133985732; Thu, 16 Nov 2023 03:26:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJnR2iDTGVBiyLONW/q3XfA8jLqJYND8GKOCtotFp7WUFdUTultF747i6hHAkQad7D5Wm1Ng== X-Received: by 2002:a2e:a4cb:0:b0:2c5:5926:de52 with SMTP id p11-20020a2ea4cb000000b002c55926de52mr5121250ljm.53.1700133985429; Thu, 16 Nov 2023 03:26:25 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id k42-20020a05600c1caa00b003feae747ff2sm3302601wms.35.2023.11.16.03.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 03:26:25 -0800 (PST) From: Javier Martinez Canillas To: Thomas Zimmermann , deller@gmx.de Cc: linux-fbdev@vger.kernel.org, Andy Walls , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH 20/32] media/ivtvfb: Initialize fb_ops to fbdev I/O-memory helpers In-Reply-To: <20231115102954.7102-21-tzimmermann@suse.de> References: <20231115102954.7102-1-tzimmermann@suse.de> <20231115102954.7102-21-tzimmermann@suse.de> Date: Thu, 16 Nov 2023 12:26:24 +0100 Message-ID: <87y1ey2b33.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Thomas Zimmermann writes: > Initialize the instance of struct fb_ops with fbdev initializer > macros for framebuffers in I/O address space. This explictily sets > the read/write, draw and mmap callbacks to the correct default > implementation. > > Fbdev drivers sometimes rely on the callbacks being NULL for a > default implementation to be invoked; hence requireing the I/O > helpers to be built in any case. Setting all callbacks in all > drivers explicitly will allow to make the I/O helpers optional. > This benefits systems that do not use these functions. > > Set the callbacks via macros. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat