From: Jani Nikula <jani.nikula@intel.com>
To: Christophe de Dinechin <christophe.de.dinechin@gmail.com>
Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Kirti Wankhede <kwankhede@nvidia.com>
Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops
Date: Thu, 28 Nov 2019 10:35:29 +0000 [thread overview]
Message-ID: <87y2w0mgpa.fsf@intel.com> (raw)
In-Reply-To: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org>
On Thu, 28 Nov 2019, Christophe de Dinechin <christophe.de.dinechin@gmail.com> wrote:
>> On 27 Nov 2019, at 17:32, Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> Now that the fbops member of struct fb_info is const, we can star making
> s/star/start/
Ooops, thanks.
BR,
Jani.
>
>> the ops const as well.
>>
>> Cc: Kirti Wankhede <kwankhede@nvidia.com>
>> Cc: kvm@vger.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> samples/vfio-mdev/mdpy-fb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
>> index 2719bb259653..21dbf63d6e41 100644
>> --- a/samples/vfio-mdev/mdpy-fb.c
>> +++ b/samples/vfio-mdev/mdpy-fb.c
>> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info)
>> iounmap(info->screen_base);
>> }
>>
>> -static struct fb_ops mdpy_fb_ops = {
>> +static const struct fb_ops mdpy_fb_ops = {
>> .owner = THIS_MODULE,
>> .fb_destroy = mdpy_fb_destroy,
>> .fb_setcolreg = mdpy_fb_setcolreg,
>> --
>> 2.20.1
>>
>
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2019-11-28 10:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 16:31 [PATCH 00/13] video, drm: constify fbops in struct fb_info Jani Nikula
2019-11-27 16:31 ` [PATCH 01/13] video: fb_defio: preserve user fb_ops Jani Nikula
2019-11-27 17:01 ` Ville Syrjälä
2019-11-27 18:09 ` [Intel-gfx] " Daniel Vetter
2019-11-27 18:17 ` Daniel Vetter
2019-11-27 18:21 ` Daniel Vetter
2019-11-28 9:09 ` Jani Nikula
2019-11-28 10:05 ` Daniel Vetter
2019-11-28 10:08 ` Daniel Vetter
2019-11-28 10:34 ` Jani Nikula
2019-11-27 16:31 ` [PATCH 02/13] drm/fb-helper: don't preserve fb_ops across deferred IO use Jani Nikula
2019-11-27 18:18 ` [Intel-gfx] " Daniel Vetter
2019-11-28 11:31 ` Noralf Trønnes
2019-11-28 12:05 ` [Intel-gfx] " Jani Nikula
2019-11-28 14:03 ` Noralf Trønnes
2019-11-27 16:31 ` [PATCH 03/13] video: smscufx: don't restore fb_mmap after deferred IO cleanup Jani Nikula
2019-11-27 18:20 ` [Intel-gfx] " Daniel Vetter
2019-11-27 16:32 ` [PATCH 04/13] video: udlfb: " Jani Nikula
2019-11-27 18:22 ` Daniel Vetter
2019-11-27 16:32 ` [PATCH 05/13] video: fbdev: vesafb: modify the static fb_ops directly Jani Nikula
2019-11-27 18:23 ` Daniel Vetter
2019-11-27 16:32 ` [PATCH 06/13] video: fbmem: use const pointer for fb_ops Jani Nikula
2019-11-27 16:32 ` [PATCH 07/13] video: omapfb: " Jani Nikula
2019-11-27 16:32 ` [PATCH 08/13] video: fbdev: make fbops member of struct fb_info a const pointer Jani Nikula
2019-11-28 9:36 ` kbuild test robot
2019-11-28 10:46 ` kbuild test robot
2019-11-27 16:32 ` [PATCH 09/13] drm: constify fb ops across all drivers Jani Nikula
2019-11-27 16:32 ` [PATCH 10/13] video: " Jani Nikula
2019-11-27 16:32 ` [PATCH 11/13] HID: picoLCD: constify fb ops Jani Nikula
2019-11-27 16:32 ` [PATCH 12/13] media: constify fb ops across all drivers Jani Nikula
2019-11-27 16:32 ` [PATCH 13/13] samples: vfio-mdev: constify fb ops Jani Nikula
2019-11-27 18:29 ` Daniel Vetter
2019-11-28 9:22 ` Jani Nikula
2019-11-28 10:11 ` Daniel Vetter
2019-11-28 8:31 ` Christophe de Dinechin
2019-11-28 10:35 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2w0mgpa.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=christophe.de.dinechin@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).