From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Thu, 28 Nov 2019 10:35:29 +0000 Subject: Re: [PATCH 13/13] samples: vfio-mdev: constify fb ops Message-Id: <87y2w0mgpa.fsf@intel.com> List-Id: References: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> In-Reply-To: <39B62C70-3E60-48AB-8F11-534EF5B8EFBD@dinechin.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe de Dinechin Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kirti Wankhede On Thu, 28 Nov 2019, Christophe de Dinechin wrote: >> On 27 Nov 2019, at 17:32, Jani Nikula wrote: >> >> Now that the fbops member of struct fb_info is const, we can star making > s/star/start/ Ooops, thanks. BR, Jani. > >> the ops const as well. >> >> Cc: Kirti Wankhede >> Cc: kvm@vger.kernel.org >> Signed-off-by: Jani Nikula >> --- >> samples/vfio-mdev/mdpy-fb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c >> index 2719bb259653..21dbf63d6e41 100644 >> --- a/samples/vfio-mdev/mdpy-fb.c >> +++ b/samples/vfio-mdev/mdpy-fb.c >> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info) >> iounmap(info->screen_base); >> } >> >> -static struct fb_ops mdpy_fb_ops = { >> +static const struct fb_ops mdpy_fb_ops = { >> .owner = THIS_MODULE, >> .fb_destroy = mdpy_fb_destroy, >> .fb_setcolreg = mdpy_fb_setcolreg, >> -- >> 2.20.1 >> > -- Jani Nikula, Intel Open Source Graphics Center