From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471EBC63777 for ; Mon, 23 Nov 2020 17:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEE10206E3 for ; Mon, 23 Nov 2020 17:06:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BtEofZ03" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389922AbgKWRGM (ORCPT ); Mon, 23 Nov 2020 12:06:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44156 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389763AbgKWRGM (ORCPT ); Mon, 23 Nov 2020 12:06:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606151171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ETdBmUCF01QVQJOZ+sQu9TUGQeVKu9xOEmE1E5gBvfU=; b=BtEofZ03By1sp6OyH8lSI6IT4Bb/Q48OsWV2XnBXmdgQcceGh9rKSaQV86czSHO4W4CJHn vUaUaH4n0l1WmtKl1NY4JjZQEtZdHR6F0okj/kLdyZp+LnqjvTzaYPmjipu9+IS6RcbTNg lanzsvwsZXvmVS2IMlU/0SstZMlkjqs= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-BN6d9FMtMFqOBEXfWky-fQ-1; Mon, 23 Nov 2020 12:06:09 -0500 X-MC-Unique: BN6d9FMtMFqOBEXfWky-fQ-1 Received: by mail-qt1-f200.google.com with SMTP id l67so14061725qte.6 for ; Mon, 23 Nov 2020 09:06:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ETdBmUCF01QVQJOZ+sQu9TUGQeVKu9xOEmE1E5gBvfU=; b=WiYrl30G460rsF8gMV1+EB07ku02JxmQISDjcVvRDAdCOz06NgD+NZkYhTHRxd0/kI zWiOSiTyFahDFSDk7DAz2NZ6u0KIf8gMuLKKGe0yN21kOqpUH11s4N4ZDgbG+6QgV/zi NeRONZz5T0Fv1vbXQog8cUpVNvGiO7ZI+NYV2lEnCcnnC6Nl4360H8Xgy0EvfNSDqJND 4ZdnhMb/YBr1BOk+W4uQA68f3BSyuFQKb6yObGbTDdOZg9/2m9wyojNFHgz6j4TuHZ+H IF0+azqQzIZp+m+ogGqJ4vHqIPHYA8hrQjrIVJkaGHxYZm4WOT4vg++CdQ9YhNqhBELb txSg== X-Gm-Message-State: AOAM533U1x+QlrJOBmIIrGNd0XB8LoT4lhtphud6WP3e7ajl2VTpCgfZ 8UeBwk1FZFWd2emQmto6EZedwaOY+mE9mS2kpUMyrj4fgsjaX7QRem1Ce7H93SpJbBoOVRHPaSD ijEJTQbGT6IZyZapzdW5hgvw= X-Received: by 2002:ac8:5d53:: with SMTP id g19mr70874qtx.354.1606151168818; Mon, 23 Nov 2020 09:06:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHR8oVpP3xv7xpCkK6lH4mawBfXgRI3GL2dEiLGp13/vfLrDKV7SBtsWnvpv2iFDtHltekRw== X-Received: by 2002:ac8:5d53:: with SMTP id g19mr70839qtx.354.1606151168572; Mon, 23 Nov 2020 09:06:08 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o187sm10226153qkb.120.2020.11.23.09.06.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Nov 2020 09:06:07 -0800 (PST) Subject: Re: [RFC] MAINTAINERS tag for cleanup robot To: Joe Perches , clang-built-linux@googlegroups.com Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, tboot-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, netdev@vger.kernel.org, linux-media@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, keyrings@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, alsa-devel@alsa-project.org, bpf@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-nfs@vger.kernel.org, patches@opensource.cirrus.com References: <20201121165058.1644182-1-trix@redhat.com> <2105f0c05e9eae8bee8e17dcc5314474b3c0bc73.camel@perches.com> <6e8c1926-4209-8f10-d0f9-72c875a85a88@redhat.com> <859bae8ddae3238116824192f6ddf1c91a381913.camel@perches.com> From: Tom Rix Message-ID: <88eeba27-ee36-df63-8cd9-3cccbe5e0850@redhat.com> Date: Mon, 23 Nov 2020 09:06:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <859bae8ddae3238116824192f6ddf1c91a381913.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 11/22/20 10:22 AM, Joe Perches wrote: > On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote: >> On 11/21/20 9:10 AM, Joe Perches wrote: >>> On Sat, 2020-11-21 at 08:50 -0800, trix@redhat.com wrote: >>>> A difficult part of automating commits is composing the subsystem >>>> preamble in the commit log. For the ongoing effort of a fixer producing >>>> one or two fixes a release the use of 'treewide:' does not seem appropriate. >>>> >>>> It would be better if the normal prefix was used. Unfortunately normal is >>>> not consistent across the tree. >>>> >>>> So I am looking for comments for adding a new tag to the MAINTAINERS file >>>> >>>> D: Commit subsystem prefix >>>> >>>> ex/ for FPGA DFL DRIVERS >>>> >>>> D: fpga: dfl: >>> I'm all for it. Good luck with the effort. It's not completely trivial. >>> >>> From a decade ago: >>> >>> https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/ >>> >>> (and that thread started with extra semicolon patches too) >> Reading the history, how about this. >> >> get_maintainer.pl outputs a single prefix, if multiple files have the >> same prefix it works, if they don't its an error. >> >> Another script 'commit_one_file.sh' does the call to get_mainainter.pl >> to get the prefix and be called by run-clang-tools.py to get the fixer >> specific message. > It's not whether the script used is get_maintainer or any other script, > the question is really if the MAINTAINERS file is the appropriate place > to store per-subsystem patch specific prefixes. > > It is. > > Then the question should be how are the forms described and what is the > inheritance priority. My preference would be to have a default of > inherit the parent base and add basename(subsystem dirname). > > Commit history seems to have standardized on using colons as the separator > between the commit prefix and the subject. > > A good mechanism to explore how various subsystems have uses prefixes in > the past might be something like: > > $ git log --no-merges --pretty='%s' - | \ > perl -n -e 'print substr($_, 0, rindex($_, ":") + 1) . "\n";' | \ > sort | uniq -c | sort -rn Thanks, I have shamelessly stolen this line and limited the commits to the maintainer. I will post something once the generation of the prefixes is done. Tom