From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Date: Fri, 02 Aug 2019 19:33:13 +0000 Subject: Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites Message-Id: <8968c928-5712-03a9-68df-051f5b58fdbc@nvidia.com> List-Id: References: <20190802021653.4882-1-jhubbard@nvidia.com> <20190802080554.GD2332@hirez.programming.kicks-ass.net> In-Reply-To: <20190802080554.GD2332@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Zijlstra , john.hubbard@gmail.com Cc: linux-fbdev@vger.kernel.org, Jan Kara , kvm@vger.kernel.org, Dave Hansen , Dave Chinner , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, Dan Williams , devel@driverdev.osuosl.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, x86@kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , xen-devel@lists.xenproject.org, devel@lists.orangefs.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, LKML , linux-xfs@ On 8/2/19 1:05 AM, Peter Zijlstra wrote: > On Thu, Aug 01, 2019 at 07:16:19PM -0700, john.hubbard@gmail.com wrote: > >> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d >> ("mm: introduce put_user_page*(), placeholder versions"). That commit >> has an extensive description of the problem and the planned steps to >> solve it, but the highlites are: > > That is one horridly mangled Changelog there :-/ It looks like it's > partially duplicated. Yeah. It took so long to merge that I think I was no longer able to actually see the commit description, after N readings. sigh > > Anyway; no objections to any of that, but I just wanted to mention that > there are other problems with long term pinning that haven't been > mentioned, notably they inhibit compaction. > > A long time ago I proposed an interface to mark pages as pinned, such > that we could run compaction before we actually did the pinning. > This is all heading toward marking pages as pinned, so we should finally get there. I'll post the RFC for tracking pinned pages shortly. thanks, -- John Hubbard NVIDIA