From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 974BA214A94 for ; Sun, 29 Jun 2025 12:08:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751198887; cv=none; b=ooINryHARcxocZJxyhFLuJqOmS0F81+gjqlkZNqVXoSV9Q+a6JKVXqIq17IMgjGfM2Zqcopajp2cxMzBhpAmN762pmQyiAITiCL45aUfYkVk1XdOxzYO8YStUgK9Aq4ASrPIxMDJ5g7tmAcR6K4aPmJFqym3qCi3kYyu86NYp/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751198887; c=relaxed/simple; bh=Bd4ZFb5mI/vt0MlkmiVCP1yVrwm4sXAQYCfiPh8N3BA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RdIJ77y97c5XVTJcBt2zvnn3DmNXUwFTVKJXwkGpNsW9lZ/pn7E4ZDxS1GHJIHoe12+ghuckWPVEIIVnGrru891VbfLCMjRSx29wuMfA91k8fM/1ZTnJmTkRO9FPGtKzp23lH2aMRMIFyQP3CRgX1+Pcu9T991xbFUSX5H+Ilro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AcSwfLw+; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AcSwfLw+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751198884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y61uksNXY3bfxfbmhRvj/wWi6127GwpvTiXCWAuJy7Y=; b=AcSwfLw+eR77dtav8RM5UgkU0RGUt+2bIs7ZQjYUEjgx5mZjp1u36XjAjuwdhhpYiW2JAW xzTVFrRSE2AxHXqIdsPjQS+g1gkB9spo/OrjUaahDOpHBjlIqBfAkioc1IRmqxGOFEl7L8 CYklQjDBIiJZ7xh8FEjOTut4cwSKuSg= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-Gi0A26P2OBysWZRnsmWfqQ-1; Sun, 29 Jun 2025 08:08:02 -0400 X-MC-Unique: Gi0A26P2OBysWZRnsmWfqQ-1 X-Mimecast-MFC-AGG-ID: Gi0A26P2OBysWZRnsmWfqQ_1751198881 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ae0d798398bso248903166b.1 for ; Sun, 29 Jun 2025 05:08:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751198881; x=1751803681; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y61uksNXY3bfxfbmhRvj/wWi6127GwpvTiXCWAuJy7Y=; b=VcDTxCQq8pnB8eW5rqq+MTzvOwyRp8Y+A3uTqtmdXcnsU8hZwWSZ29TBk2LBZDI3EX 0AVLBkedTEZcqxIy2ngctTO1Xd7NzV2b/s6X6rXlLca/kqYCKUQYQEzf6Q70d0Iv6oQq c6jCc0eln39w2uzu1gqqWBrHu2VdJ/kJQoZ0g4kQe1rjj/7zFzVKI0qzD0Acg7iZbK04 iKmH8teHEDJs6ck0A8JXg6Lur/AfuDEg4m8k0O6iy7FRxMT8dyRAvo19wQsLX3iQ7GUc LVR28Smbvv8OBs9QK4r0TNm4fbP0KENF0q9wzgYmf4gx7tY0YWSjD71plVlaXQHrWVTL pvQg== X-Forwarded-Encrypted: i=1; AJvYcCXI/et+shVnkJauzyuTZUlxpkdbJR03oP+ZVNxnrXOIcFdJiEPPw1STwV09lPPZoWhMxfdyEwuUCNidLA==@vger.kernel.org X-Gm-Message-State: AOJu0YyWaMPXgd9VldomSs19+E6m/+a7tx/mbRF34BR1bldt9Xfs71FM iTDg5lwZaZ7ONgU35RDtQTFpgG4rkCotJPJjFchf0iCLKjhQNZ1UftV8FoET5jxVqgimiqBsyRo BdN2n9U9XkitNLoDG7xD+xkuvS7UJyZ6Js2XrniqGba5F3ShNVew10XD8wCpJdjq4 X-Gm-Gg: ASbGnctFVaRmyGdkwZzEuhBf3MfmdoKIzqNWUgdviB2dToiF2ozah2WIvBu6I+AVSsL QiMVb5En++lb5yYnFcBmvsUh1H8cCXVfPRIuIt0xB/3QiedSP06JIb78KqFNlDV43h78n4Rcs7e pWhEDc3I9FuiiWS3BmDad0+i+Ms/SZNDbnpMFz/Ds3sVquht9YyGbqp9vDzvbelPYN50lXSTLHC FRZU3pt9KrvvQ74oC9GV7SMhwayAGFBueEx4uoxwi1hWSKxusXclODSjSvVO8EHmcxszQP/04rZ nDdr6wL/zCvfVzXCe9l/+hhLhTNd5WhFQtUd6dg8XOb0ZPpS+hxKD21Mhy2o1IPZppyMO1oUpfm t7O4TEdw52OXkDkIjiV0hlCEnfP7eloZR01ukiOwMLWJREiFR3D+P+eN3BSFJ+/ME0qxkYjgdwA == X-Received: by 2002:a17:907:7207:b0:ae3:6b52:f7dd with SMTP id a640c23a62f3a-ae36b52f88amr514353666b.46.1751198881151; Sun, 29 Jun 2025 05:08:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IET079+lNS2Zrgoqy9+whMR/tx3pQQ8PudfiWv0ZLtWOTerBzl2nFJIzCBrV1Me9yEUFQUboA== X-Received: by 2002:a17:907:7207:b0:ae3:6b52:f7dd with SMTP id a640c23a62f3a-ae36b52f88amr514350466b.46.1751198880619; Sun, 29 Jun 2025 05:08:00 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c6bc2dsm490353166b.136.2025.06.29.05.07.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jun 2025 05:07:59 -0700 (PDT) Message-ID: <8a3ad930-bfb1-4531-9d34-fdf7d437f352@redhat.com> Date: Sun, 29 Jun 2025 14:07:58 +0200 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property To: Krzysztof Kozlowski , Luca Weiss Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250623-simple-drm-fb-icc-v2-0-f69b86cd3d7d@fairphone.com> <20250623-simple-drm-fb-icc-v2-1-f69b86cd3d7d@fairphone.com> <20250627-mysterious-optimistic-bird-acaafb@krzk-bin> <1129bc60-f9cb-40be-9869-8ffa3b3c9748@kernel.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <1129bc60-f9cb-40be-9869-8ffa3b3c9748@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Krzysztof, On 28-Jun-25 1:49 PM, Krzysztof Kozlowski wrote: > On 27/06/2025 11:48, Luca Weiss wrote: >> Hi Krzysztof, >> >> On Fri Jun 27, 2025 at 10:08 AM CEST, Krzysztof Kozlowski wrote: >>> On Mon, Jun 23, 2025 at 08:44:45AM +0200, Luca Weiss wrote: >>>> Document the interconnects property which is a list of interconnect >>>> paths that is used by the framebuffer and therefore needs to be kept >>>> alive when the framebuffer is being used. >>>> >>>> Acked-by: Thomas Zimmermann >>>> Signed-off-by: Luca Weiss >>>> --- >>>> Documentation/devicetree/bindings/display/simple-framebuffer.yaml | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>>> index 296500f9da05e296dbbeec50ba5186b6b30aaffc..f0fa0ef23d91043dfb2b220c654b80e2e80850cd 100644 >>>> --- a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>>> +++ b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>>> @@ -79,6 +79,9 @@ properties: >>>> power-domains: >>>> description: List of power domains used by the framebuffer. >>>> >>>> + interconnects: >>>> + description: List of interconnect paths used by the framebuffer. >>>> + >>> >>> maxItems: 1, or this is not a simple FB anymore. Anything which needs >>> some sort of resources in unknown way is not simple anymore. You need >>> device specific bindings. >> >> The bindings support an arbitrary number of clocks, regulators, >> power-domains. Why should I artificially limit the interconnects to only >> one? > > And IMO they should not. Bindings are not supposed to be generic. The simplefb binding is a binding to allow keeping the firmware, e.g. uboot setup framebuffer alive to e.g. show a boot splash until the native display-engine drive loads. Needing display-engine specific bindings totally contradicts the whole goal of It is generic by nature and I really do not see how clocks and regulators are any different then interconnects here. Note that we had a huge discussion about adding clock and regulators to simplefb many years ago with pretty much the same arguments against doing so. In the end it was decided to add regulator and clocks support to the simplefb bindings and non of the feared problems with e.g. ordening of turning things on happened. A big part of this is that the claiming of clks / regulators / interconnects by the simplefb driver is there to keep things on, so it happens before the kernel starts tuning off unused resources IOW everything is already up and running and this really is about avoiding turning things off. Regards, Hans