From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Date: Tue, 13 Mar 2018 03:29:27 +0000 Subject: Re: [PATCH] video: fbdev: via: remove VLA usage Message-Id: <8e3b270d-b615-e58c-fd6e-f677e7e892e8@embeddedor.com> List-Id: References: <20180308173949.GA19305@embeddedgus> <20180309105940.22hd2uy2mv7wahzb@imgtec.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Emil Velikov , Eric Engestrom Cc: Florian Tobias Schandinat , Bartlomiej Zolnierkiewicz , linux-fbdev , Kees Cook , kernel-hardening@lists.openwall.com, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , "Gustavo A. R. Silva" On 03/09/2018 05:02 AM, Emil Velikov wrote: > On 9 March 2018 at 10:59, Eric Engestrom wrote: >> On Thursday, 2018-03-08 11:39:49 -0600, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wvla, remove VLA usage. >>> >>> Also, fixed as part of the directive to remove all VLAs from >>> the kernel: https://lkml.org/lkml/2018/3/7/621 >>> >>> Signed-off-by: Gustavo A. R. Silva >> >> Sorry for my reply on v1, I missed that Emil already replied to another >> post of the same patch (side note on that, making use of `-vX` and >> `--in-reply-to` helps track the evolution of patches) >> Yep. I know. It is just that some people prefer vX in a new thread. Anyway, I will take this into account for the next time. >> This looks good to me: >> Reviewed-by: Eric Engestrom >> > Same here > Reviewed-by: Emil Velikov > > -Emil > Thanks for reviewing it, guys. -- Gustavo A. R. Silva