Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: FlorianSchandinat@gmx.de, b.zolnierkie@samsung.com
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: via: hide unused procfs helpers
Date: Fri, 13 Jul 2018 09:41:30 +0000	[thread overview]
Message-ID: <8ec19785-5b1d-09e8-07b2-6ace8c45348e@huawei.com> (raw)
In-Reply-To: <20180713075625.11252-1-yuehaibing@huawei.com>

Pls ignore this.there has a fix:

[PATCH] fbdev/via: fix defined but not used warning

On 2018/7/13 15:56, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
> 
> drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
>  static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
>             ^
> fix this by adding #ifdef around it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/video/fbdev/via/viafbdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
> index d2f7850..edca3e0 100644
> --- a/drivers/video/fbdev/via/viafbdev.c
> +++ b/drivers/video/fbdev/via/viafbdev.c
> @@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
>  
>  #endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
>  
> +#ifdef CONFIG_PROC_FS
>  static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
>  {
>  	via_odev_to_seq(m, supported_odev_map[
>  		viaparinfo->shared->chip_info.gfx_chip_name]);
>  	return 0;
>  }
> +#endif
>  
>  static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
>  {
> 


      reply	other threads:[~2018-07-13  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  7:56 [PATCH] video: fbdev: via: hide unused procfs helpers YueHaibing
2018-07-13  9:41 ` YueHaibing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ec19785-5b1d-09e8-07b2-6ace8c45348e@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox