From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brown Date: Wed, 13 Jul 2011 17:49:46 +0000 Subject: Re: [PATCH 5/5] drivers/video/msm/mdp.c: adjust error handling code Message-Id: <8ya4o2q2hqd.fsf@huya.qualcomm.com> List-Id: References: <1309788705-22278-5-git-send-email-julia@diku.dk> <20110713081318.GB13701@linux-sh.org> In-Reply-To: <20110713081318.GB13701@linux-sh.org> (Paul Mundt's message of "Wed, 13 Jul 2011 17:13:19 +0900") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mundt Cc: Julia Lawall , kernel-janitors@vger.kernel.org, Daniel Walker , Bryan Huntsman , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Jul 13 2011, Paul Mundt wrote: >> I wonder if the error handling code at the end of the function should be >> calling clk_put as well? In that case, having a separate label for this >> case would be useful. Otherwise, one of error_request_irq and error_get_clk >> can be deleted >> > The MSM implementation for it is simply a nop, so it's not going to > really matter one way or the other. In terms of general consistency it > might be worth implementing. Today, at least. Hopefully this will get better, since we can turn off our clocks. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.