* [PATCH] fbdev/gxt4500: Use dev_err instead printk leftover.
@ 2025-11-10 16:52 Javier Garcia
2025-11-14 17:03 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Javier Garcia @ 2025-11-10 16:52 UTC (permalink / raw)
To: deller; +Cc: linux-fbdev, dri-devel, linux-kernel, shuah, Javier Garcia
I coundn't test as not have that hw but cross compiled to check the code
change.
Fixes: a3d899839064 ("[PATCH] Fbdev driver for IBM GXT4500P videocards")
Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
---
drivers/video/fbdev/gxt4500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index 15a82c6b609e..27a46e364419 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -704,7 +704,7 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
info->var = var;
if (gxt4500_set_par(info)) {
- printk(KERN_ERR "gxt4500: cannot set video mode\n");
+ dev_err(&pdev->dev, "gxt4500: cannot set video mode\n");
goto err_free_cmap;
}
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev/gxt4500: Use dev_err instead printk leftover.
2025-11-10 16:52 [PATCH] fbdev/gxt4500: Use dev_err instead printk leftover Javier Garcia
@ 2025-11-14 17:03 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2025-11-14 17:03 UTC (permalink / raw)
To: Javier Garcia; +Cc: linux-fbdev, dri-devel, linux-kernel, shuah
On 11/10/25 17:52, Javier Garcia wrote:
> I coundn't test as not have that hw but cross compiled to check the code
> change.
>
> Fixes: a3d899839064 ("[PATCH] Fbdev driver for IBM GXT4500P videocards")
> Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
> ---
> drivers/video/fbdev/gxt4500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-14 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 16:52 [PATCH] fbdev/gxt4500: Use dev_err instead printk leftover Javier Garcia
2025-11-14 17:03 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).